Fix Slack adapter to parse app_mention events#540
Open
mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
Open
Fix Slack adapter to parse app_mention events#540mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
This adds support for the app_mention event type to the Slack Socket Mode adapter, and injects a was_mentioned flag into the metadata. Also fixes two upstream clippy warnings found during test verification.
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for parsing the
app_mentionevent type to the Slack Socket Mode adapter, injecting awas_mentionedflag into the metadata.Without this, the bot ignores messages when it is purely @mentioned without regular message context.
Changes
crates/openfang-channels/src/slack.rs- addapp_mentionto parsed events and inject awas_mentionedflag into metadata.crates/openfang-cli/src/main.rs,crates/openfang-runtime/src/kernel_handle.rs- Fixed two unrelated clippy warnings on upstreammainthat caused linting to fail.Backward compatibility
Checklist
cargo fmtcargo test --workspaceandcargo clippy --workspace --all-targets -- -D warningsunsafecode