build: Add optional Docker build args to speed up Cargo builds#541
Open
mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
Open
build: Add optional Docker build args to speed up Cargo builds#541mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
mdrissel wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Adds LTO and CODEGEN_UNITS arguments that default to optimized prod settings but can be overridden (e.g., LTO=false, CODEGEN_UNITS=16) by developers for faster iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds optional build arguments (
LTOandCODEGEN_UNITS) to theDockerfile, defaulting to the existing production-optimized profile settings.These parameters allow developers who are frequently rebuilding the Docker image to skip Link Time Optimization and increase codegen units using
--build-arg, massively speeding up the container build times without affecting the default optimized release binary.Details
ARG LTO=trueandARG CODEGEN_UNITS=1added to keep parity withCargo.toml[profile.release]default.docker build --build-arg LTO=false --build-arg CODEGEN_UNITS=16 .for ultra-fast iteration.Checklist