feat: ops-traces seed skill + ns-agent-admin connector template - #21
Merged
Conversation
Read-only ops telemetry path for the ns-agent service: a seed playbook (ops-traces) that unlocks the existing rest pack, plus an ns-agent-admin REST connector template (agent.nextsolutions.studio, vault label ns_agent_admin_key) seeded by the work vault recipe. - SKILL_NAME_PACK_HINTS + PACK_SKILL_NAMES map ops-traces to the rest pack (PACK_SKILL_NAMES values now allow a list; scrape/media/… output unchanged) - SEED_REVISION bumped v1.7.9 -> v1.9.2 so existing installs refresh - No new agent tools; playbook drives rest_request only
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ops-tracesseed skill (packages/core/src/skills/store.ts) — read-only ops playbook for the ns-agent service: setup of the admin connector,GET /v1/ops/summary?days=Nas the primary telemetry call,/v1/runs+/v1/conversationsfor detail, read-only/no-secrets/summarize rules, and plainly-stated known gaps (ns-exec audit log has no read endpoint, Mac vault audit is CLI-only, no Discord REST tools — ask Combons_ops_report).ns-agent-adminREST connector template (connectors/templates.ts, exported fromindex.ts) —https://agent.nextsolutions.studio, Bearer via vault labelns_agent_admin_key, modeled exactly on thens-exectemplate.vault/recipes.ts) seeds the connector + addsns_agent_admin_keyto the secret-label checklist.SKILL_NAME_PACK_HINTS["ops-traces"] = TOOL_PACKS.rest(gating.ts) andPACK_SKILL_NAMES.rest = ["combo-rest", "ops-traces"](promptCatalog.ts).PACK_SKILL_NAMESvalues now acceptstring | string[]; single-string packs render exactly as before (covered by the existingscrape → combo-scrapetest).SEED_REVISION→v1.9.2so existing installs refresh seeds. No package.json version bumps.rest_requestagainst the connector.Acceptance evidence (local gates, same as CI)
pnpm typecheck(tsc --build): green (exit 0, no errors)pnpm test(vitest run): 104 test files passed, 649 tests passed / 6 skipped / 0 failed (skips are the env-gatedllm-evalsuite, pre-existing)store.test.tsseed list 18 → 19 (ops-tracesadded, rest-pack toolHints asserted);docs/SKILLS.mdtable row added (OOTB seeds 17 → 18)origin/main; unrelated PR feat(browser): within row-scoping, excludeSelector, list_form_fields, stuck-loop guard (1.9.0) #20 branch untouchedDeployment note
Pairs with an ns-infra PR adding
GET /v1/ops/summaryto the ns-agent service — not yet deployed. Until that lands,rest_requestonns-agent-adminwill 404; this is expected and documented in the playbook body./v1/runsand/v1/conversationsshould work as soon as the ops key is in the vault label.Test plan
skill_read ops-traces, ask "conversations yesterday" → summary from/v1/ops/summaryns_agent_admin_key(no value in chat)