Skip to content

Task 1 completed#8

Open
piyuuussh wants to merge 2 commits into
RitwikSingh28:mainfrom
piyuuussh:Piyush-assn1
Open

Task 1 completed#8
piyuuussh wants to merge 2 commits into
RitwikSingh28:mainfrom
piyuuussh:Piyush-assn1

Conversation

@piyuuussh

@piyuuussh piyuuussh commented Sep 2, 2023

Copy link
Copy Markdown

The task 1 contain two page of hard code of the given ui having one landing page which contain horizontal and vertical scrollable boxes and and one completely functional box that can redirect to the next page called detailed page. The detailed page contain a functional back and like button. I have used all the same photos as given in the ui and tried to replicate as close as possible.
cons:

  1. its not responsive as i have used sized box and defined the height and width with all precision (Will take care of these things from next time)
  2. Since i have used the same images as in ui so 2 of them is half image so its not complete image when you'll scroll them(it looks completely though till you dont scroll).

below i have attached the image of ui of both page.
landing page
page2

@RitwikSingh28

RitwikSingh28 commented Sep 24, 2023

Copy link
Copy Markdown
Owner

@piyuuussh
It was directed to create your project: inside the folder: Task1/<your-name>.

Kindly do this change ASAP

@RitwikSingh28

Copy link
Copy Markdown
Owner

Also, write a proper description following the specifications mentioned in the document provided.
Only then, will I further inspect your code.

Keep in mind to include the changes in this PR.
Do NOT create a new PR

@piyuuussh

Copy link
Copy Markdown
Author

@RitwikSingh28 Sir
I have created a subdirectory named Piyush and made the required changes.

@RitwikSingh28

Copy link
Copy Markdown
Owner

@piyuuussh, please create a proper description for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants