Skip to content

[codex] Add semantic search Roam API types#61

Merged
mdroidian merged 3 commits into
mainfrom
codex/add-semantic-search-types
Jun 9, 2026
Merged

[codex] Add semantic search Roam API types#61
mdroidian merged 3 commits into
mainfrom
codex/add-semantic-search-types

Conversation

@mdroidian

@mdroidian mdroidian commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds TypeScript coverage for the new Roam semantic search API surface:

  • exports SemanticSearchArgs, SemanticSearchHit, and SemanticSearch
  • declares window.roamAlphaAPI.data.semanticSearchEnabled()
  • declares window.roamAlphaAPI.data.async.semanticSearch(...)

No mock environment defaults are included.

Impact

Extension authors can now call the new async semantic search API with typed arguments and hit records. Callers can use semanticSearchEnabled() before invoking the async API, matching Roam's availability guard contract.

Validation

  • npm run build passes
  • npm run lint passes with one existing warning in src/types/index.ts
  • npm test was previously blocked during test loading by existing missing modules: ../src/backend/getRoamJSUser and react-dom/client

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a6358d53-44e2-4522-b1ac-247fe903cd97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mdroidian mdroidian marked this pull request as ready for review June 9, 2026 05:51
@mdroidian

Copy link
Copy Markdown
Collaborator Author

@codex review

devin-ai-integration[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

charliecreates[bot]

This comment was marked as resolved.

@mdroidian mdroidian marked this pull request as draft June 9, 2026 06:04
@mdroidian mdroidian marked this pull request as ready for review June 9, 2026 06:04
@mdroidian mdroidian merged commit d172c2e into main Jun 9, 2026
2 checks passed
@mdroidian mdroidian deleted the codex/add-semantic-search-types branch June 9, 2026 06:05
@charliecreates

charliecreates Bot commented Jun 9, 2026

Copy link
Copy Markdown

Picked this up from the earlier ready_for_review trigger, but this PR is already merged, so no further review/action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant