Repository navigation
ci: publish on Node 24 instead of upgrading npm - #528
Merged
Merged
Conversation
Sonar flagged `npm install -g npm@11` in the publish job: it runs lifecycle scripts and installs an unpinned version. Node 24 releases bundle npm 11.19 (>= 11.15.0, needed for `npm stage publish`), so use Node 24 and drop the install. check-latest keeps the runner from using an older cached Node 24.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sonar fails the quality gate (security rating) on new code. Both findings are on
.github/workflows/release-please.yml:47,npm install -g npm@11:--ignore-scripts).Change
The step only existed to get npm >= 11.15.0 for
npm stage publish. Node 24 already bundles it (24.19.0: npm 11.17.0; 24.20.0 and 24.21.0: npm 11.19.0, per nodejs.org/dist/index.json). The publish job now usesnode-version: 24withcheck-latest: true, so the runner does not use an older cached Node 24, and the install step is removed.Not verified
The publish job runs only on a release or a manual run, so this PR's CI does not exercise it. The next publish (2.0.1) will.