Add support for adamw-type optimizers#99
Merged
RobertTLange merged 4 commits intoRobertTLange:mainfrom Apr 2, 2026
Merged
Conversation
Owner
|
Thanks, Theo. I added a real regression test covering an actual optax.adamw ask/eval/tell loop, and I also tightened the dependency window plus CI config so the existing matrix can run reliably again. Once this rerun finishes green, I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for the wonderful library!
I noticed that there was no support for adamw-type optimizers, which is a shame as regularization is known to help find more stable minima.
I wanted to add these, it is a simple change: adding the
state.meanas an argument when callingupdateon the optimizer. Optax's API supports this and yourcore.optimizeralso does. So this doesn't break anything (hopefully). All tests have passed. I was thinkning about adding a specific test for this but I couldn't find a nice way to insert this given your current test structure. I've opted for simply adding adamw in the rl notebook. Let me know if you want something different.