-
-
Notifications
You must be signed in to change notification settings - Fork 35
Replacing esbuild with rolldown
#3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughReplaced Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
esbuild with rolldownesbuild with rolldown
Does not work well for `unrun`, causes unclear crashes and resolution uncertainty over `ramda` in #3054 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated module import paths and TypeScript compilation configuration for improved build compatibility. * Standardized JSON module import syntax across the codebase. * Enhanced internal API infrastructure with extended interface support for advanced use cases. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
53dfa2a to
9913bdd
Compare
esbuild with rolldownesbuild with rolldown
|
Filed an issue to |
# Conflicts: # cjs-test/quick-start.spec.ts # pnpm-lock.yaml
# Conflicts: # package.json # pnpm-lock.yaml # pnpm-workspace.yaml
esbuild with rolldownesbuild with rolldown
|
The experiment is a success. |
# Conflicts: # pnpm-lock.yaml
|
Can now use |
# Conflicts: # package.json # pnpm-lock.yaml
|
I noticed that |
# Conflicts: # pnpm-lock.yaml
90fcd3e to
bb5f3c2
Compare
# Conflicts: # pnpm-lock.yaml
Includes:
tsxwithunrun#3051vitetorolldown-vite#3053Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.