fix(ui): the export dialog reports a failure only once the job has settled - #803
Merged
Merged
Conversation
JArmandoAnaya
force-pushed
the
fix/export-dialog-running-job-error
branch
from
August 26, 2026 12:42
a535bbd to
1ca336e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
While an export job was still
queuedorrunning, the export dialog showed The export stopped without saying why. under the Exporting badge, and the sentence vanished on its own once the job succeeded. The condition that picks the job to explain treated every state other thansucceededas a stop; it now asksisSettledfirst, so a failure sentence belongs only to a job that has actually finished asfailedorcancelled.The condition has been this way since the job system arrived; it went unnoticed because the jsdom tests only ever rendered the dialog at one settled state per test, and a real export is fast enough that the sentence flashes.
frontend/ui-core/src/screens/DatasetScreen.tsx:stoppedrequiresisSettled(job).frontend/ui-core/src/screens/dataset.test.tsx: a test renders the dialog atqueuedand atrunningand asserts noexport-job-error.Checks
pnpm --filter @visionset/ui-core test(62 files, 1378 passed),pnpm -r lint,pnpm -r build. The new test fails onmainand passes here.