Extract the design system to @robomous/ui-core - #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What moved
The design system — 21 shadcn Nova primitives with their snapshots, the
lib/helpers (cn,inlineLink,menuSurface,twoLineTrigger,progressAria),statusTone, the foundation tokens/stylesheet (shadcn preset +brand), the shadcn tooling, and the design-system gates — now lives in Robomous/ui-core, published as@robomous/ui-core@0.1.0.Re-export strategy: public API unchanged
@visionset/ui-corere-exports the whole package surface (export * from "@robomous/ui-core"), so every previously importable name still imports from the same place.LIGHT_THEME/DARK_THEMEare re-exported as the merged view (foundation + extensions), so callers readingLIGHT_THEME.stagekeep working unchanged.Extension layering
VisionSet keeps what is VisionSet's:
stage, the threeorigin-*marks, and the shell's four layout tokens, declared in the extensionstyles.css(which imports the foundation stylesheet first) and mirrored by the extensiontokens.ts— shadcn's own extension convention, gated.Gate split
@robomous/ui-core/gates:frontend/ui-core/src/tokens.test.ts(extension agreement, no foundation shadowing, merged view lost nothing),tests/scripts/design_system.test.mjs(vocabulary discipline over our own sources), and a thinnedtests/scripts/design_tokens.test.mjs(coloured classes, brand sites, retired declarations, icon set, tailwind-config refusal).Cool-down exclusion
@robomous/ui-coreis added tominimumReleaseAgeExclude: it is first-party, released from our own CI minutes before it is consumed here — the supply-chain cool-down guards third-party releases.Verification performed
check.sh --fastPASSED (python, frontend, generated) against the published package..jsextensions in dist, missing type declarations for./gates).