Platformio does not build on main

[giopde1ste]

The current main of the libraries does not compile when trying to compile with platformio, I think we are missing a lib in the platformio.ini
@Hoog-V I'm pretty sure this is your code, you know which lib is missing?

Also here is the build output

Verbose mode can be enabled via `-v, --verbose` option
CONFIGURATION: https://docs.platformio.org/page/boards/atmelsam/adafruit_feather_m0_express.html
PLATFORM: Atmel SAM (8.1.0) > Adafruit Feather M0 Express
HARDWARE: SAMD21G18A 48MHz, 32KB RAM, 256KB Flash
DEBUG: Current (atmel-ice) External (atmel-ice, blackmagic, jlink)
PACKAGES:
 - framework-arduino-samd-adafruit @ 1.7.10
 - framework-cmsis @ 2.50400.181126 (5.4.0)
 - framework-cmsis-atmel @ 1.2.2
 - toolchain-gccarmnoneeabi @ 1.90301.200702 (9.3.1)
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 13 compatible libraries
Scanning dependencies...
Dependency Graph
|-- FreeRTOS_SAMD21 @ 2.3.0+sha.6967660
|-- Wire @ 1.0
|-- Sensor
Building in release mode
Compiling .pio\build\samd21\src\BreathingControl.cpp.o
Compiling .pio\build\samd21\src\Compression.cpp.o
Compiling .pio\build\samd21\src\main.cpp.o
In file included from src\BreathingControl.hpp:33,
                 from src\BreathingControl.cpp:29:
lib\Manikin_Software_Libraries\modules\hal_gpio\src/gpio.hpp:35:5: warning: inline variables are only available with '-std=c++17' or 
'-std=gnu++17'
   35 |     inline constexpr uint8_t kGPIODirInput = 0x00;
      |     ^~~~~~
lib\Manikin_Software_Libraries\modules\hal_gpio\src/gpio.hpp:36:5: warning: inline variables are only available with '-std=c++17' or 
'-std=gnu++17'
   36 |     inline constexpr uint8_t kGPIODirOutput = 0x01;
      |     ^~~~~~
In file included from src\BreathingControl.hpp:33,
                 from src\main.cpp:3:
lib\Manikin_Software_Libraries\modules\hal_gpio\src/gpio.hpp:35:5: warning: inline variables are only available with '-std=c++17' or 
'-std=gnu++17'
   35 |     inline constexpr uint8_t kGPIODirInput = 0x00;
      |     ^~~~~~
lib\Manikin_Software_Libraries\modules\hal_gpio\src/gpio.hpp:36:5: warning: inline variables are only available with '-std=c++17' or 
'-std=gnu++17'
   36 |     inline constexpr uint8_t kGPIODirOutput = 0x01;
      |     ^~~~~~
Compiling .pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_exception\src\hal_exception.cpp.o
Compiling .pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_logger\src\hal_log_flash.cpp.o
Compiling .pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_logger\src\hal_log_serial.cpp.o
Compiling .pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_spi\src\spi_mainboard.cpp.o
Compiling .pio\build\samd21\lib0d0\Manikin_Software_Libraries\i2c\src\i2c_helper.cpp.o
In file included from lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log.hpp:30,
                 from lib\Manikin_Software_Libraries\modules\hal_exception\src/hal_exception.hpp:32,
                 from lib\Manikin_Software_Libraries\modules\hal_exception\src\hal_exception.cpp:29:
lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log_base.hpp:31:10: fatal error: SdFat.h: No such file or directory        

***************************************************************
* Looking for SdFat.h dependency? Check our library registry!
*
* CLI  > platformio lib search "header:SdFat.h"
* Web  > https://registry.platformio.org/search?q=header:SdFat.h
*
***************************************************************

   31 | #include <SdFat.h>
      |          ^~~~~~~~~
compilation terminated.
In file included from lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log_serial.hpp:31,
                 from lib\Manikin_Software_Libraries\modules\hal_logger\src\hal_log_serial.cpp:28:
lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log_base.hpp:31:10: fatal error: SdFat.h: No such file or directory        

***************************************************************
* Looking for SdFat.h dependency? Check our library registry!
*
* CLI  > platformio lib search "header:SdFat.h"
* Web  > https://registry.platformio.org/search?q=header:SdFat.h
*
***************************************************************

   31 | #include <SdFat.h>
      |          ^~~~~~~~~
compilation terminated.
In file included from lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log_flash.hpp:30,
Compiling .pio\build\samd21\FrameworkArduinoVariant\variant.cpp.o
                 from lib\Manikin_Software_Libraries\modules\hal_logger\src\hal_log_flash.cpp:28:
lib\Manikin_Software_Libraries\modules\hal_logger\src/hal_log_base.hpp:31:10: fatal error: SdFat.h: No such file or directory
Compiling .pio\build\samd21\FrameworkArduino\IPAddress.cpp.o

***************************************************************
* Looking for SdFat.hCompiling .pio\build\samd21\FrameworkArduino\Print.cpp.o
 dependency? Check our library registry!
*
* CLI  > platformio lib search "header:SdFat.h"
* Web  > https://registry.platformio.org/search?q=header:SdFat.h
*
***************************************************************

   31 | #include <SdFat.h>
      |          ^~~~~~~~~
compilation terminated.
*** [.pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_exception\src\hal_exception.cpp.o] Error 1
*** [.pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_logger\src\hal_log_serial.cpp.o] Error 1
*** [.pio\build\samd21\lib0d0\Manikin_Software_Libraries\hal_logger\src\hal_log_flash.cpp.o] Error 1

[Hoog-V]

The library depends on the SdFat.h from adafruit library:
add this to your libdeps in platformio.ini:
https://github.com/adafruit/Adafruit_SPIFlash.git

[Hoog-V]

Including:

#include <SdFat.h>

In main.cpp after the arduino include fixes this problem.

[giopde1ste]

Il leave this issue open cause I feel like this is gonna happen again to somebody at some point