Dependencies missing from deb packages

[farshbafdoustar]

Expected Behavior

rosbridge_websocket running

Actual Behavior

process[rosbridge_websocket-1]: started with pid [122]
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/rosbridge_server/rosbridge_websocket", line 38, in
from twisted.python import log
ImportError: No module named twisted.python

Steps to Reproduce the Problem

1. installing the version ros-kinetic-rosbridge-suite_0.11.5 on Ubuntu Xenial (inside kinetic-ros-base-xenial)
   ....
   Setting up ros-kinetic-rosbridge-msgs (0.11.5-1xenial-20200413-135822+0000) ...
   Setting up ros-kinetic-rosbridge-server (0.11.5-1xenial-20200413-140154+0000) ...
   Setting up ros-kinetic-rosbridge-suite (0.11.5-1xenial-20200413-140413+0000) ...
   .....

Specifications

• ROS Version (echo $ROS_DISTRO):kinetic
• OS Version (grep DISTRIB_CODENAME /etc/lsb-release): xenial
• Rosbridge Version (roscat rosbridge_server package.xml | grep '<version>'): 0.11.5
• Twisted Version (python -c 'import twisted; print twisted.version'):
  Traceback (most recent call last):
  File "", line 1, in
  ImportError: No module named twisted

[mvollrath]

I see, the package depends for rosbridge_server are broken in 0.11.5. Probably something to do with #460. Maybe the CI needs to be updated to use the new package format. @sfalexrog

[mvollrath]

Seems like this doesn't affect melodic, only kinetic.

[farshbafdoustar]

Thanks for the reply.
I have checked with rosdep from source files "tag:0.11.5" and it seems the following packages are missing as ros-kinetic-rosbridge-suite package dependency :

• python-twisted
• python-twisted-bin
• python-twisted-core
• python-autobahn
• python-tornado
• python-backports.ssl-match-hostname
• python-imaging
• python-pil

[mvollrath]

Workaround for this is installing the packages listed by @farshbafdoustar (thank you for the list)

Also requires dependencies:

• python-bson
• python-bson-ext

[mvollrath]

As of today this is affecting melodic packages too.

[moriarty]

👍 also experienced this issue today. does the ros build farm support package format 3 for all previous releases?

Is "ROS_PYTHON_VERSION" always set? or should it be defaulting to python2

[mvollrath]

If nobody has answers within a week or so I'm reverting the change that caused this problem and making a release for the next sync.

[moriarty]

I see here:

https://github.com/ros/ros_comm/blob/melodic-devel/clients/rospy/package.xml

It’s setup very similar, and works. @jacobperron or @wjwwood when/where must ROS_PYTHON_VERSION must be to have the dependencies in the Debs set up properly?
Are the dependencies missing because the ROS_PYTHON_VERSION not set when they ran bloom?

ROS1 only uses python2 out of the box so I would assume that is what the debians would ship with python2 for all ROS1 versions, and to use python3 you need to clone export ROS_PYTHON_VERSION, setup a ROS workspace, run rosdep install (this will get the py3 deps) and then compile everything.

[wjwwood]

Are the dependencies missing because the ROS_PYTHON_VERSION not set when they ran bloom?

I don't think that matters, but I didn't implement that feature. ros-infrastructure/bloom#551 might have the info you guys need.

[mvollrath]

It sounds like maybe we just need to bloom with an up-to-date bloom tool?

[msmcconnell]

@mvollrath Based on your comment ~4 days ago, this will be fixed in the next kinetic sync. Is that correct?

[mvollrath]

I've released 0.11.6 for kinetic and melodic, they should appear in the next sync for each distribution.

Confirmed that the previous release was made with bloom 0.8.0 which did not have the patch linked by William. This version will have Python (2) dependencies.