fix(auth): default iris login to production server URL#59
Closed
frafaelcb wants to merge 2 commits into
Closed
Conversation
`DEFAULT_SERVER` was falling back to `http://localhost:3000` when the `IRIS_SERVER_URL` env var was not set. Users running `iris login` without any flags were being sent to a local address instead of the production platform. Changed the fallback to `https://iris.clickbus.com` so the browser-based OAuth flow targets production out of the box. The `IRIS_SERVER_URL` env var and `--server` flag continue to work as overrides for local dev. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…_URL Two more places in cli.py still fell back to http://localhost:3000: - iris login --token (manual/CI login path) - iris install (fetches install.sh from the platform) Both updated to https://iris.clickbus.com to match auth.py. Also added IRIS_SERVER_URL to the README environment variables table so users know how to override it for local development. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Analisar depois pssibildiade de usar URL na vercel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_SERVERe outros dois fallbacks no código usavamhttp://localhost:3000quandoIRIS_SERVER_URLnão estava definida. Usuários executandoiris login(ouiris install) sem configuração prévia eram direcionados para localhost em vez da plataforma de produção.Além disso,
IRIS_SERVER_URLnão estava documentada no README — usuários de dev local não tinham como saber que podiam sobrescrevê-la.Arquivos alterados:
iris/platform/auth.pybrowser_login→ produçãoiris/cli.pyiris login --token→ produçãoiris/cli.pyiris install→ produçãoREADME.mdIRIS_SERVER_URLdocumentadaComportamento
iris login(sem flags, sem env)http://localhost:3000/cli/authorize?...https://iris.clickbus.com/cli/authorize?...iris login --token <tok>http://localhost:3000https://iris.clickbus.comiris installhttp://localhost:3000/install.shhttps://iris.clickbus.com/install.shIRIS_SERVER_URL=http://localhost:3000 iris loginiris login --server http://localhost:3000Test Plan
iris loginsem configuração — confirmar que abrehttps://iris.clickbus.com/cli/authorize?...IRIS_SERVER_URL=http://localhost:3000 iris login— confirmar que ainda abre localhostiris login --server http://localhost:3000— confirmar que ainda abre localhostiris install— confirmar que baixa dehttps://iris.clickbus.com/install.shIRIS_SERVER_URLaparece na tabela de variáveis de ambiente🤖 Generated with Claude Code