Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Adds SubscriptionRead and ISubscriptionBridge - #43

Open
marceloschmidt wants to merge 14 commits into
alphafrom
subscription-read
Open

Adds SubscriptionRead and ISubscriptionBridge#43
marceloschmidt wants to merge 14 commits into
alphafrom
subscription-read

Conversation

@marceloschmidt

@marceloschmidt marceloschmidt commented Jul 31, 2018

Copy link
Copy Markdown
Member

Implemented here: RocketChat/Rocket.Chat#15549

@graywolf336 graywolf336 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we moved too slow on this and the definitions repo is no longer accessible, we need to move the definitions over to this pull request.

@graywolf336 graywolf336 added the ⏳ in progress Items which are currently a work in progress label Oct 7, 2019
Merge branch 'master' into subscription-read

# Conflicts:
#	package-lock.json
#	src/server/accessors/Reader.ts
#	src/server/accessors/index.ts
#	src/server/bridges/AppBridges.ts
#	src/server/bridges/index.ts
#	src/server/managers/AppAccessorManager.ts
#	tests/server/accessors/Reader.spec.ts
#	tests/test-data/bridges/appBridges.ts
@CLAassistant

CLAassistant commented Oct 8, 2019

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Oct 8, 2019

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.04%. Comparing base (d3fe543) to head (b83acd8).
Report is 529 commits behind head on alpha.

Files with missing lines Patch % Lines
src/server/accessors/RoomSubscriptionRead.ts 33.33% 4 Missing ⚠️
src/server/compiler/AppCompiler.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha      #43      +/-   ##
==========================================
+ Coverage   53.05%   55.04%   +1.99%     
==========================================
  Files          74       83       +9     
  Lines        2754     2885     +131     
  Branches      408      408              
==========================================
+ Hits         1461     1588     +127     
- Misses       1293     1297       +4     
Files with missing lines Coverage Δ
src/server/accessors/Reader.ts 100.00% <100.00%> (ø)
src/server/accessors/index.ts 100.00% <100.00%> (ø)
src/server/bridges/AppBridges.ts 100.00% <ø> (ø)
src/server/bridges/index.ts 100.00% <ø> (ø)
src/server/managers/AppAccessorManager.ts 100.00% <100.00%> (ø)
src/server/compiler/AppCompiler.ts 26.03% <0.00%> (ø)
src/server/accessors/RoomSubscriptionRead.ts 33.33% <33.33%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fe543...b83acd8. Read the comment docs.

@d-gubert
d-gubert changed the base branch from master to alpha May 8, 2020 18:40
@graywolf336 graywolf336 removed the ⏳ in progress Items which are currently a work in progress label May 11, 2020
@graywolf336
graywolf336 requested review from d-gubert and shiqimei and removed request for rodrigok May 11, 2020 15:17
@graywolf336
graywolf336 dismissed their stale review May 11, 2020 15:18

Changes have been made.

@graywolf336

Copy link
Copy Markdown
Contributor

subscription-testing_0.0.12.zip

Here is the app to run to test. It simply logs the subscription's of a room to the logger (aka don't do it on a big room otherwise the logs will be filled).

Comment thread src/definition/subscriptions/IRoomSubscriptionIterator.ts Outdated
Comment thread tsconfig.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants