Adds SubscriptionRead and ISubscriptionBridge - #43
Conversation
graywolf336
left a comment
There was a problem hiding this comment.
Since we moved too slow on this and the definitions repo is no longer accessible, we need to move the definitions over to this pull request.
Merge branch 'master' into subscription-read # Conflicts: # package-lock.json # src/server/accessors/Reader.ts # src/server/accessors/index.ts # src/server/bridges/AppBridges.ts # src/server/bridges/index.ts # src/server/managers/AppAccessorManager.ts # tests/server/accessors/Reader.spec.ts # tests/test-data/bridges/appBridges.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #43 +/- ##
==========================================
+ Coverage 53.05% 55.04% +1.99%
==========================================
Files 74 83 +9
Lines 2754 2885 +131
Branches 408 408
==========================================
+ Hits 1461 1588 +127
- Misses 1293 1297 +4
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
subscription-testing_0.0.12.zip Here is the app to run to test. It simply logs the subscription's of a room to the logger (aka don't do it on a big room otherwise the logs will be filled). |
Implemented here: RocketChat/Rocket.Chat#15549