Skip to content

fix: handleOpenEmojiPicker to Insert Actual Emoji Instead of Shortcode in Chat Composer#35461

Closed
thepiyush-303 wants to merge 1 commit intoRocketChat:developfrom
thepiyush-303:fix/AddEmojiFromEmojiPicker
Closed

fix: handleOpenEmojiPicker to Insert Actual Emoji Instead of Shortcode in Chat Composer#35461
thepiyush-303 wants to merge 1 commit intoRocketChat:developfrom
thepiyush-303:fix/AddEmojiFromEmojiPicker

Conversation

@thepiyush-303
Copy link
Copy Markdown
Contributor

@thepiyush-303 thepiyush-303 commented Mar 11, 2025

Screencast.from.2025-03-11.14-57-19.webm

Proposed changes (including videos or screenshots)

Used emojione package to convert it into unicode(actualEmoji).

Issue(s)

Closes #35460

Steps to test or reproduce

Further comments

@thepiyush-303 thepiyush-303 requested a review from a team as a code owner March 11, 2025 09:35
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Mar 11, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: f50c9fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sujiiiiit
Copy link
Copy Markdown

will it work for custom emojis ??

@thepiyush-303
Copy link
Copy Markdown
Contributor Author

will it work for custom emojis ??

I don't think so.

@engelgabriel
Copy link
Copy Markdown
Member

Closing this PR in favor of #39411, where we’re replacing Emojione with native Unicode emojis.

It’s still a draft, and we’d love help from the community to get it across the finish line 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emoji Picker Inserts Shortcode Instead of Actual Emoji in Chat Composer

3 participants