fix: add autocomplete attribute to 2FA input fields#38411
fix: add autocomplete attribute to 2FA input fields#38411Avanish-Gupta-CSE wants to merge 2 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a46b472 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughAdded the HTML attribute Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds autocomplete="one-time-code" to TOTP and Email 2FA input fields for better password manager compatibility (KeePassXC, Bitwarden, etc.) Fixes RocketChat#30025
a6cd720 to
8d03b0e
Compare
|
Hi team, just checking in on this PR. The CI checks are all passing. Is there anything I can do to help move this forward? Happy to make any adjustments if needed. Thank you! |
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's duplicated now and it has been fixed here: #37014 Questions? Help needed? Feature Requests?
|
Proposed changes (including videos or screenshots)
Adds
autocomplete="one-time-code"attribute to the 2FA TOTP and Email code input fields to improve password manager compatibility (KeePassXC, Bitwarden, 1Password, etc.).Changes
TwoFactorTotpModal.tsx- AddedautoComplete='one-time-code'to TextInputTwoFactorEmailModal.tsx- AddedautoComplete='one-time-code'to TextInputThis follows the W3C recommendation for one-time code fields.
Issue(s)
Fixes #30025
Steps to test or reproduce
Further comments
This is a minimal, focused fix addressing the accessibility issue. The
autocomplete="one-time-code"attribute is the standard way to identify OTP fields per HTML specification.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.