chore: fix correct spelling of 'occurred' in error messages#38436
chore: fix correct spelling of 'occurred' in error messages#38436laky241 wants to merge 16 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
WalkthroughCorrects a consistent spelling error across seven files, changing "occured" to "occurred" in error messages, log statements, a comment, and a test assertion. No functional or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38436 +/- ##
===========================================
- Coverage 70.97% 70.93% -0.04%
===========================================
Files 3197 3197
Lines 113347 113347
Branches 20571 20553 -18
===========================================
- Hits 80450 80408 -42
- Misses 30843 30894 +51
+ Partials 2054 2045 -9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Found a spelling typo while exploring the codebase - "occured" should be "occurred" (double 'r'). Fixed it across 7 files in error messages, log statements, and code comments to keep everything consistent.
Files changed:
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.tsee/packages/media-calls/src/sip/providers/IncomingSipCall.tsee/packages/media-calls/src/sip/providers/OutgoingSipCall.tspackages/apps-engine/src/server/AppManager.tspackages/apps-engine/src/server/errors/CompilerError.tspackages/apps-engine/tests/server/errors/CompilerError.spec.tspackages/media-signaling/src/lib/Call.tsIssue(s)
No existing issue - found this while reading through the code.
Steps to test or reproduce
No testing needed - these are just string corrections. You can verify by:
Further comments
Small fix but helps maintain code quality. All instances of the typo have been updated for consistency.
Summary by CodeRabbit
COMM-144