Skip to content

chore: fix correct spelling of 'occurred' in error messages#38436

Open
laky241 wants to merge 16 commits intoRocketChat:developfrom
laky241:fix-typo-occurred-spelling
Open

chore: fix correct spelling of 'occurred' in error messages#38436
laky241 wants to merge 16 commits intoRocketChat:developfrom
laky241:fix-typo-occurred-spelling

Conversation

@laky241
Copy link
Copy Markdown

@laky241 laky241 commented Jan 30, 2026

Proposed changes (including videos or screenshots)

Found a spelling typo while exploring the codebase - "occured" should be "occurred" (double 'r'). Fixed it across 7 files in error messages, log statements, and code comments to keep everything consistent.

Files changed:

  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
  • packages/apps-engine/src/server/AppManager.ts
  • packages/apps-engine/src/server/errors/CompilerError.ts
  • packages/apps-engine/tests/server/errors/CompilerError.spec.ts
  • packages/media-signaling/src/lib/Call.ts

Issue(s)

No existing issue - found this while reading through the code.

Steps to test or reproduce

No testing needed - these are just string corrections. You can verify by:

Further comments

Small fix but helps maintain code quality. All instances of the typo have been updated for consistency.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling of "occurred" in error messages and log outputs across the app to improve clarity and consistency.
    • Updated related test expectations to match corrected messages.
    • Minor comment spelling fixes to keep developer-facing text consistent.

COMM-144

@laky241 laky241 requested a review from a team as a code owner January 30, 2026 11:29
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jan 30, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 8.4.0, but it targets 8.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: 2d40d28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 30, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71e07269-4af8-49a5-a549-8e1133410d26

📥 Commits

Reviewing files that changed from the base of the PR and between 3a69f90 and 2b025df.

📒 Files selected for processing (1)
  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build

Walkthrough

Corrects a consistent spelling error across seven files, changing "occured" to "occurred" in error messages, log statements, a comment, and a test assertion. No functional or control-flow changes.

Changes

Cohort / File(s) Summary
SAML Authentication
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
Fixed spelling in error HTML response heading.
Media Calls SIP Providers
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts, ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
Corrected typo in modify-event error log messages.
Apps Engine
packages/apps-engine/src/server/AppManager.ts, packages/apps-engine/src/server/errors/CompilerError.ts, packages/apps-engine/tests/server/errors/CompilerError.spec.ts
Fixed comment spelling, corrected CompilerError message, and updated test expectation.
Media Signaling
packages/media-signaling/src/lib/Call.ts
Fixed spelling in WebRTC connection-state error log.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and accurately describes the main change: fixing the spelling of 'occurred' in error messages across multiple files.
Linked Issues check ✅ Passed The PR is linked to COMM-144, a tracking issue for 8.3.0 community PRs. The typo fixes are minor community contributions aligned with this aggregate tracking issue.
Out of Scope Changes check ✅ Passed All changes are purely spelling corrections of 'occured' to 'occurred' in error messages and comments across seven files, with no functional or behavioral modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@sampaiodiego sampaiodiego changed the title fix: correct spelling of 'occurred' in error messages chore: fix correct spelling of 'occurred' in error messages Jan 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.93%. Comparing base (b29fb86) to head (2b025df).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38436      +/-   ##
===========================================
- Coverage    70.97%   70.93%   -0.04%     
===========================================
  Files         3197     3197              
  Lines       113347   113347              
  Branches     20571    20553      -18     
===========================================
- Hits         80450    80408      -42     
- Misses       30843    30894      +51     
+ Partials      2054     2045       -9     
Flag Coverage Δ
e2e 60.41% <ø> (-0.08%) ⬇️
e2e-api 48.25% <ø> (-0.03%) ⬇️
unit 71.63% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Feb 3, 2026
@aleksandernsilva aleksandernsilva added this to the 8.2.0 milestone Feb 3, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 3, 2026
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2026
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Mar 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
@dionisio-bot dionisio-bot bot enabled auto-merge March 11, 2026 12:59
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Mar 11, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2026
@dionisio-bot dionisio-bot bot enabled auto-merge March 11, 2026 19:01
@scuciatto scuciatto modified the milestones: 8.3.0, 8.4.0 Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: QA assured Means it has been tested and approved by a company insider type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants