Skip to content

refactor(admin-user-info): remove any usage and enforce strict typing in AdminUserInfoActions #39041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srijnabhargav wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor(admin-user-info): remove any usage and enforce strict typing in AdminUserInfoActions #39041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/meteor/client/views/admin/users/AdminUserInfoActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type { ReactElement } from 'react';
import { useMemo } from 'react';
import { useTranslation } from 'react-i18next';

import type { AdminUserInfoActionsProps } from './hooks/useAdminUserInfoActions';
import type { AdminUserAction, AdminUserInfoActionsProps } from './hooks/useAdminUserInfoActions';
import { useAdminUserInfoActions } from './hooks/useAdminUserInfoActions';
import { UserInfoAction } from '../../../components/UserInfo';

Expand Down Expand Up @@ -47,9 +47,8 @@ const AdminUserInfoActions = ({
);
}, [t, menuOptions]);

// TODO: sanitize Action type to avoid any
const actions = useMemo(() => {
const mapAction = ([key, { content, title, icon, onClick, disabled }]: any): ReactElement => (
const mapAction = ([key, { content, title, icon = 'kebab', onClick, disabled }]: [string, AdminUserAction]): ReactElement => (
<UserInfoAction key={key} title={title} label={content} onClick={onClick} disabled={disabled} icon={icon} />
);
return [...actionsDefinition.map(mapAction), menu].filter(Boolean);
Expand Down
1 change: 1 addition & 0 deletions apps/meteor/client/views/admin/users/hooks/useAdminUserInfoActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export type AdminUserAction = {
title?: string;
variant?: 'danger';
onClick: () => void;
disabled?: boolean;
};

type AdminUserMenuAction = {
Expand Down
Loading