refactor: migrate emoji provider to emoji-toolkit#39214
Closed
CodeMatrix1 wants to merge 2 commits intoRocketChat:developfrom
Closed
refactor: migrate emoji provider to emoji-toolkit#39214CodeMatrix1 wants to merge 2 commits intoRocketChat:developfrom
CodeMatrix1 wants to merge 2 commits intoRocketChat:developfrom
Conversation
Note: needs asset generation and also legacy of emojione naming is kept unchanged as much as possible
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
WalkthroughCodebase-wide migration from emojione to emoji-toolkit (joypixels): imports, property names, and function calls updated; emoji asset paths adjusted; package dependencies updated. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodeMatrix1
changed the title
CodeMatrix1
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs">
<violation number="1" location="apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs:14">
P1: Dead property reference `emojioneList` - should be `emojiList` in server file</violation>
<violation number="2" location="apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs:14">
P1: Dead reference to undefined `emojione` variable in sprite rendering path</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs (1)
16-18:⚠️ Potential issue | 🟡 MinorUpdate the error message to reference the correct package.
The error message still references
emojione-assets, but should referenceemoji-assetsto match the updated dependency.Proposed fix
if (!fs.existsSync(emojiJsonFile)) { console.error(`${emojiJsonFile} doesn't exist.`); - console.error("Maybe you need to run 'meteor npm install emojione-assets' or 'meteor npm install'?"); + console.error("Maybe you need to run 'meteor npm install emoji-assets' or 'meteor npm install'?"); } else {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs` around lines 16 - 18, Update the error message that checks fs.existsSync(emojiJsonFile) to reference the new package name; replace the string "emojione-assets" with "emoji-assets" in the console.error call that currently suggests running 'meteor npm install emojione-assets' so the suggestion reflects the updated dependency and uses emojiJsonFile for context.
🧹 Nitpick comments (2)
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts (2)
1-7: Module mutation via property reassignment.Line 7 mutates the imported
joypixelsmodule by reassigning itsunicodeCharRegexmethod. This is a side effect that affects all other consumers of the module. While this works, it's worth noting this approach couples the memoization to module load order.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts` around lines 1 - 7, The code currently mutates the imported joypixels module by reassigning joypixels.unicodeCharRegex to a memoized version; instead create a local memoized wrapper and use that wherever unicodeCharRegex is needed. Replace the reassignment with a const like memoizedUnicodeCharRegex = mem(joypixels.unicodeCharRegex, { maxAge: 1000 }) (or export it) and update any local uses (in this file or helpers) to call memoizedUnicodeCharRegex rather than joypixels.unicodeCharRegex so you avoid mutating the imported module while keeping the memoization via mem.
82-94: Module mutation by overwritingshortnameToImage.This overwrites
joypixels.shortnameToImageglobally, affecting all consumers of theemoji-toolkitmodule. This is intentional for the custom rendering logic, but be aware this is a global side effect.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts` around lines 82 - 94, Currently the code mutates the global emoji-toolkit object by assigning to joypixels.shortnameToImage; instead define a local function (e.g., getShortnameToImage) that uses joypixels.regShortNames, convertShortName, joypixels.ascii, joypixels.riskyMatchAscii, joypixels.regAsciiRisky, joypixels.regAscii and convertUnicode to perform the same replacements, and export/return that function from this module instead of overwriting joypixels.shortnameToImage so you avoid global side effects while preserving the custom rendering behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts`:
- Line 77: The return expression in getEmojiConfig references an undefined
symbol emojione (emojione.fileExtension) causing a ReferenceError; fix by either
importing the emojione module or replacing the reference with the correct
existing variable (for example emojioneConfig or whatever variable holding
fileExtension in this file) and ensure the imported/used symbol provides
fileExtension so the template using ePath and unicode works; update the
top-of-file imports to import emojione (or the correct config) or change the
identifier in the return line to the existing config variable.
---
Outside diff comments:
In `@apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs`:
- Around line 16-18: Update the error message that checks
fs.existsSync(emojiJsonFile) to reference the new package name; replace the
string "emojione-assets" with "emoji-assets" in the console.error call that
currently suggests running 'meteor npm install emojione-assets' so the
suggestion reflects the updated dependency and uses emojiJsonFile for context.
---
Nitpick comments:
In `@apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts`:
- Around line 1-7: The code currently mutates the imported joypixels module by
reassigning joypixels.unicodeCharRegex to a memoized version; instead create a
local memoized wrapper and use that wherever unicodeCharRegex is needed. Replace
the reassignment with a const like memoizedUnicodeCharRegex =
mem(joypixels.unicodeCharRegex, { maxAge: 1000 }) (or export it) and update any
local uses (in this file or helpers) to call memoizedUnicodeCharRegex rather
than joypixels.unicodeCharRegex so you avoid mutating the imported module while
keeping the memoization via mem.
- Around line 82-94: Currently the code mutates the global emoji-toolkit object
by assigning to joypixels.shortnameToImage; instead define a local function
(e.g., getShortnameToImage) that uses joypixels.regShortNames, convertShortName,
joypixels.ascii, joypixels.riskyMatchAscii, joypixels.regAsciiRisky,
joypixels.regAscii and convertUnicode to perform the same replacements, and
export/return that function from this module instead of overwriting
joypixels.shortnameToImage so you avoid global side effects while preserving the
custom rendering behavior.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (8)
apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjsapps/meteor/app/emoji-emojione/lib/getEmojiConfig.tsapps/meteor/app/emoji-emojione/server/callbacks.tsapps/meteor/app/emoji/client/lib.tsapps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.tsapps/meteor/client/views/root/hooks/useEmojiOne.tsapps/meteor/package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/app/emoji-emojione/server/callbacks.tsapps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.tsapps/meteor/client/views/root/hooks/useEmojiOne.tsapps/meteor/app/emoji/client/lib.tsapps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
🧠 Learnings (11)
📓 Common learnings
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/app/emoji-emojione/server/callbacks.tsapps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.tsapps/meteor/client/views/root/hooks/useEmojiOne.tsapps/meteor/app/emoji/client/lib.tsapps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/app/emoji-emojione/server/callbacks.tsapps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.tsapps/meteor/client/views/root/hooks/useEmojiOne.tsapps/meteor/app/emoji/client/lib.tsapps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
📚 Learning: 2026-01-17T01:51:47.764Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38219
File: packages/core-typings/src/cloud/Announcement.ts:5-6
Timestamp: 2026-01-17T01:51:47.764Z
Learning: In packages/core-typings/src/cloud/Announcement.ts, the AnnouncementSchema.createdBy field intentionally overrides IBannerSchema.createdBy (object with _id and optional username) with a string enum ['cloud', 'system'] to match existing runtime behavior. This is documented as technical debt with a FIXME comment at apps/meteor/app/cloud/server/functions/syncWorkspace/handleCommsSync.ts:53 and should not be flagged as an error until the runtime behavior is corrected.
Applied to files:
apps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/views/root/hooks/useEmojiOne.ts
📚 Learning: 2026-02-25T20:10:16.987Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38913
File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34
Timestamp: 2026-02-25T20:10:16.987Z
Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out.
Applied to files:
apps/meteor/app/lib/server/lib/sendNotificationsOnMessage.tsapps/meteor/client/views/root/hooks/useEmojiOne.tsapps/meteor/app/emoji/client/lib.ts
📚 Learning: 2026-02-24T19:36:55.089Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 38493
File: apps/meteor/tests/e2e/page-objects/fragments/home-content.ts:60-82
Timestamp: 2026-02-24T19:36:55.089Z
Learning: In RocketChat/Rocket.Chat e2e tests (apps/meteor/tests/e2e/page-objects/fragments/home-content.ts), thread message preview listitems do not have aria-roledescription="message", so lastThreadMessagePreview locator cannot be scoped to messageListItems (which filters for aria-roledescription="message"). It should remain scoped to page.getByRole('listitem') or mainMessageList.getByRole('listitem').
Applied to files:
apps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.ts
📚 Learning: 2026-01-19T18:17:46.433Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38262
File: apps/meteor/client/lib/utils/normalizeMessagePreview/getMessagePreview.ts:24-33
Timestamp: 2026-01-19T18:17:46.433Z
Learning: In the Rocket.Chat repository, usernames (lastMessage.u.username) and display names (lastMessage.u.name) are sanitized/escaped centrally elsewhere in the system, so individual display functions like getMessagePreview do not need to escape these values before interpolating them into strings.
Applied to files:
apps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.ts
📚 Learning: 2025-11-19T18:20:07.720Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: packages/i18n/src/locales/en.i18n.json:918-921
Timestamp: 2025-11-19T18:20:07.720Z
Learning: Repo: RocketChat/Rocket.Chat — i18n/formatting
Learning: This repository uses a custom message formatting parser in UI blocks/messages; do not assume standard Markdown rules. For keys like Call_ended_bold, Call_not_answered_bold, Call_failed_bold, and Call_transferred_bold in packages/i18n/src/locales/en.i18n.json, retain the existing single-asterisk emphasis unless maintainers request otherwise.
Applied to files:
apps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.ts
📚 Learning: 2026-02-10T16:32:42.586Z
Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38528
File: apps/meteor/client/startup/roles.ts:14-14
Timestamp: 2026-02-10T16:32:42.586Z
Learning: In Rocket.Chat's Meteor client code, DDP streams use EJSON and Date fields arrive as Date objects; do not manually construct new Date() in stream handlers (for example, in sdk.stream()). Only REST API responses return plain JSON where dates are strings, so implement explicit conversion there if needed. Apply this guidance to all TypeScript files under apps/meteor/client to ensure consistent date handling in DDP streams and REST responses.
Applied to files:
apps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.tsapps/meteor/client/views/root/hooks/useEmojiOne.ts
📚 Learning: 2026-02-24T19:09:09.561Z
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Applied to files:
apps/meteor/client/views/root/hooks/useEmojiOne.ts
📚 Learning: 2025-12-10T21:00:54.909Z
Learnt from: KevLehman
Repo: RocketChat/Rocket.Chat PR: 37091
File: ee/packages/abac/jest.config.ts:4-7
Timestamp: 2025-12-10T21:00:54.909Z
Learning: Rocket.Chat monorepo: Jest testMatch pattern '<rootDir>/src/**/*.spec.(ts|js|mjs)' is valid in this repo and used across multiple packages (e.g., packages/tools, ee/packages/omnichannel-services). Do not flag it as invalid in future reviews.
Applied to files:
apps/meteor/client/views/root/hooks/useEmojiOne.ts
🧬 Code graph analysis (2)
apps/meteor/app/emoji-emojione/server/callbacks.ts (1)
apps/meteor/server/lib/callbacks.ts (1)
callbacks(218-226)
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts (1)
apps/meteor/app/emoji/client/lib.ts (1)
emoji(8-34)
🔇 Additional comments (11)
apps/meteor/app/emoji/client/lib.ts (3)
2-2: Import migration is clean and scoped correctly.Switching to
emoji-toolkithere is consistent with the PR objective and keeps this module’s interface intact.
17-17: Renderer mapping preserves behavior contract.Wiring
rendertojoypixels.toImageis the expected provider swap at this layer and keeps downstream usage unchanged.
34-34: No concerns on object closure/update boundary.This closing change is structurally fine and introduces no functional risk.
apps/meteor/app/emoji-emojione/server/callbacks.ts (1)
1-12: LGTM - Clean migration to joypixels.The import and function call are correctly updated to use
joypixels.shortnameToUnicode. The callback identifier'emojione-shortnameToUnicode'is intentionally preserved to minimize scope, which aligns with the PR objectives.apps/meteor/client/lib/utils/normalizeMessagePreview/normalizeMessagePreview.ts (1)
3-10: LGTM - Straightforward library swap.The import and usage correctly migrate to
joypixels.shortnameToUnicode. The processing order (escapeHTML→filterMarkdown→shortnameToUnicode) remains unchanged.apps/meteor/client/views/root/hooks/useEmojiOne.ts (1)
25-34: LGTM - Property name correctly updated.The change from
config.emojione.emojioneListtoconfig.emojione.emojiListcorrectly aligns with theemoji-toolkitAPI, where the emoji list is exposed asemojiListrather thanemojioneList.apps/meteor/app/lib/server/lib/sendNotificationsOnMessage.ts (2)
11-11: LGTM - Import correctly updated.
194-200: LGTM - Consistent migration across all emoji conversions.All three usages of
shortnameToUnicode(message body, attachment description, and attachment text) are correctly updated to usejoypixels. The conditional type checks are preserved.apps/meteor/app/emoji-emojione/lib/generateEmojiIndex.mjs (1)
11-14: LGTM - Path references correctly updated.The asset folder and emoji data paths are correctly updated to reference
emoji-assetsandemoji-toolkit.apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts (1)
109-118: LGTM - Configuration export structure preserved.The
getEmojiConfigexport maintains the same API surface, withemojionekey now mapping to thejoypixelsmodule. This preserves backward compatibility for consumers likeuseEmojiOne.ts.apps/meteor/package.json (1)
196-197: LGTM - Dependency migration looks correct.The dependency swap from
emojione/emojione-assetstoemoji-toolkit/emoji-assetsis aligned with the PR objectives. Both packages are at version 9.0.0, ensuring compatibility. The packages exist on npm with no known security advisories.
a small change missed Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
CodeMatrix1
changed the title
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts`:
- Line 6: Remove the inline comment "Memoize conversion functions for
performance" from the getEmojiConfig implementation in getEmojiConfig.ts; locate
the comment near the top of the file (around the getEmojiConfig function and its
memoized conversion helpers) and delete that single-line comment so the file
adheres to the repository's "Avoid code comments in the implementation"
guideline.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
🧠 Learnings (3)
📓 Common learnings
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: In Rocket.Chat PRs, keep feature PRs free of unrelated lockfile-only dependency bumps; prefer reverting lockfile drift or isolating such bumps into a separate "chore" commit/PR, and always use yarn install --immutable with the Yarn version pinned in package.json via Corepack.
Learnt from: ggazzo
Repo: RocketChat/Rocket.Chat PR: 35995
File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112
Timestamp: 2026-02-23T17:53:18.785Z
Learning: In Rocket.Chat PR reviews, maintain strict scope boundaries—when a PR is focused on a specific endpoint (e.g., rooms.favorite), avoid reviewing or suggesting changes to other endpoints that were incidentally refactored (e.g., rooms.invite) unless explicitly requested by maintainers.
Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts
🧬 Code graph analysis (1)
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts (1)
apps/meteor/app/emoji/client/lib.ts (1)
emoji(8-34)
🔇 Additional comments (4)
apps/meteor/app/emoji-emojione/lib/getEmojiConfig.ts (4)
13-47: Shortname conversion migration is consistent and preserves compatibility.This block correctly uses
joypixelsdata (emojiList,uc_full,uc_base,fileExtension) while keeping the legacyemojioneCSS class contract intact.
54-77: ASCII conversion path is correctly switched to JoyPixels APIs.The updated mapping/escape/render flow is coherent, and Line 77 now correctly references
joypixels.fileExtension.
82-107:shortnameToImageandisEmojiSupportedupdates are aligned with the provider switch.Both paths now consistently use JoyPixels regex/config toggles (
regShortNames, ASCII mode, risky ASCII mode).
109-115:getEmojiConfigexport mapping is well-scoped for a gradual migration.Keeping
emojioneas the outward key while wiring it tojoypixelsis a good compatibility bridge for this phase.
Member
|
Closing this PR in favor of #39411, where we’re replacing Emojione with native Unicode emojis. It’s still a draft, and we’d love help from the community to get it across the finish line 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces my migration architecture proposal of shifting the emoji provider from
emojionetoemoji-toolkit(JoyPixels).The changes in this PR are limited strictly to code-level migration and dependency updates, without modifying runtime logic or introducing UI or behavioral changes.
Primary changes are in
apps/meteor/app/emoji-emojione/lib, rest are just for compliance.Summary of changes
emojionetojoypixelswhere applicable.emoji-toolkit.emojioneto maintain compatibility and reduce scope in this phase.Issue Concerned
fixes #39207, #24917 and #31069
below are previously unavailable emojis - axe and face_with_peeking_eye.
Important notes
node generateEmojiIndex.mjsfromapps/meteor/app/emoji-emojione/libfor updating emoji library.emojionenaming still exists in certain filenames and structural references and has been deliberately preserved to avoid expanding the scope of this PR.Summary by CodeRabbit