feat(emoji): update emoji picker to latest version #39217
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,18 +1,18 @@ | ||||||||
| # Updating emojis (now using emoji-toolkit) | ||||||||
|
|
||||||||
| ## Generate new category map variable for emojipicker | ||||||||
| Run the generator script which now pulls metadata from `emoji-toolkit` | ||||||||
|
|
||||||||
| ``` | ||||||||
| node --experimental-modules generateEmojiIndex.mjs | ||||||||
| ``` | ||||||||
|
Comment on lines
6
to
8
Contributor
There was a problem hiding this comment. Add language specification to fenced code block. The code block is missing a language identifier, which helps with syntax highlighting and accessibility. 📝 Proposed fix-```
+```shell
node --experimental-modules generateEmojiIndex.mjs
```📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.21.0)[warning] 6-6: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||||||||
|
|
||||||||
| The script will download 64px PNGs from the JoyPixels CDN into `.emoji-cache` | ||||||||
| and build updated sprite sheets under `public/packages/emojione/`. | ||||||||
|
|
||||||||
| ## Sprite generation notes | ||||||||
| The old manual `grunt`/`sass` workflow is no longer required. If you need to | ||||||||
| rebuild sprites offline you can cache the PNG files yourself by running the | ||||||||
| script once with internet access; subsequent runs will reuse the cached images. | ||||||||
|
|
||||||||
| The generated CSS is written to `apps/meteor/app/emoji-emojione/client/emojione-sprites.css`. | ||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,281 +1,27 @@ | ||
| import emojiToolkit from 'emoji-toolkit'; | ||
|
|
||
| import { emojisByCategory, emojiCategories, toneList } from './emojiPicker'; | ||
|
|
||
| // The old file contained a large number of fixes for the outdated emojione | ||
| // library. The new toolkit is much more well behaved; we simply expose the | ||
| // functions we care about and keep the same configuration shape so the | ||
| // rest of the system (which references `emoji.packages.emojione`) continues | ||
| // working without modification. | ||
|
|
||
| export const getEmojiConfig = () => { | ||
| // emojiToolkit already includes a structured list on `emojiToolkit.emoji` or | ||
| // regardless we can re-export the raw JSON for compatibility. | ||
| const base = emojiToolkit; | ||
|
|
||
| return { | ||
| emojione: base, | ||
| sprites: true, | ||
| emojisByCategory, | ||
| emojiCategories, | ||
| toneList, | ||
| render: base.toImage, | ||
| renderPicker: base.toImage, | ||
| }; | ||
| }; | ||
|
|
||
| // legacy helper removed; this file now only exports the simple config |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,12 +1,12 @@ | ||||||
| import emojiToolkit from 'emoji-toolkit'; | ||||||
| import { Meteor } from 'meteor/meteor'; | ||||||
|
|
||||||
| import { callbacks } from '../../../server/lib/callbacks'; | ||||||
|
|
||||||
| Meteor.startup(() => { | ||||||
| callbacks.add( | ||||||
| 'beforeSendMessageNotifications', | ||||||
| (message) => emojiToolkit.shortnameToUnicode(message), | ||||||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: cat -n apps/meteor/app/emoji-emojione/server/callbacks.tsRepository: RocketChat/Rocket.Chat Length of output: 501 🏁 Script executed: # Search for emoji-toolkit package info and version
fd -e "package.json" | xargs grep -l "emoji-toolkit" 2>/dev/null | head -5Repository: RocketChat/Rocket.Chat Length of output: 48 🌐 Web query:
💡 Result: In emoji-toolkit v10.0.0,
So the main “undefined behavior” you can hit is passing a non-string input (e.g. A safe call pattern is: joypixels.shortnameToUnicode(String(value ?? ""));Citations:
🏁 Script executed: # Search for beforeSendMessageNotifications callback invocations
rg "beforeSendMessageNotifications" -A 3 -B 3Repository: RocketChat/Rocket.Chat Length of output: 2893 🏁 Script executed: # Look for callback.add patterns to understand the callback signature
rg "callbacks\.add\(" -A 5 | head -100Repository: RocketChat/Rocket.Chat Length of output: 8623 Guard callback input before calling The Safe guard- (message) => emojiToolkit.shortnameToUnicode(message),
+ (message) => (typeof message === 'string' ? emojiToolkit.shortnameToUnicode(message) : message),📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| callbacks.priority.MEDIUM, | ||||||
| 'emojione-shortnameToUnicode', | ||||||
| ); | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove practice comment from production README.
This HTML comment appears to be a test/practice addition that should not be included in the main README.
🧹 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents