Skip to content

poc: update emojitoolkit and replace emojione usage in some places#39372

Closed
MartinSchoeler wants to merge 7 commits intodevelopfrom
fix/channel-perf
Closed

poc: update emojitoolkit and replace emojione usage in some places#39372
MartinSchoeler wants to merge 7 commits intodevelopfrom
fix/channel-perf

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Mar 5, 2026

Proposed changes (including videos or screenshots)

Currently the emojione has a significant impact in performance on channels that have a lot of emojis in messages, these issues were fixed on the emoji-toolkit continuation

emojione:
Screenshot 2026-03-04 at 16 37 55

emoji-toolkit:
Screenshot 2026-03-05 at 11 14 59

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Mar 5, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: 44d9410

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6c8b3139-ae09-4104-acb6-621a65494944

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.89%. Comparing base (c68ac53) to head (44d9410).
⚠️ Report is 59 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #39372   +/-   ##
========================================
  Coverage    70.89%   70.89%           
========================================
  Files         3207     3196   -11     
  Lines       113334   113236   -98     
  Branches     20538    20515   -23     
========================================
- Hits         80349    80280   -69     
+ Misses       30940    30911   -29     
  Partials      2045     2045           
Flag Coverage Δ
unit 71.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@engelgabriel
Copy link
Copy Markdown
Member

This PR is being closed in favor of #39411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants