Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 6c5a4ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #39845 +/- ##
===========================================
+ Coverage 70.28% 70.82% +0.54%
===========================================
Files 3280 1593 -1687
Lines 116814 85878 -30936
Branches 20704 12800 -7904
===========================================
- Hits 82103 60825 -21278
+ Misses 31440 24564 -6876
+ Partials 3271 489 -2782
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🔴 Layne — 5 finding(s)Found 5 issue(s): 5 high. |
@KevLehman can you add a |
|
/layne exception-approve LAYNE-92cc1dd60a09a52c LAYNE-f3b98cfa0ce32ac8 reason: Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin |
|
✅ Exception recorded for LAYNE-92cc1dd60a09a52c, LAYNE-f3b98cfa0ce32ac8 by @julio-rocketchat: "Kevin justified that the 2 instances of ignoreSsrfValidation are actually only configured by a workspace admin". Re-running scan... |
65f09e0 to
7d82278
Compare
|
/layne exception-approve LAYNE-fa31c7e349286e51 LAYNE-67d67ea80c17baca LAYNE-955f7ddec71ff37f reason: same as before, only configurable by admins |
|
✅ Exception recorded for LAYNE-fa31c7e349286e51, LAYNE-67d67ea80c17baca, LAYNE-955f7ddec71ff37f by @julio-rocketchat: "same as before, only configurable by admins". Re-running scan... |
42b379c to
ee03976
Compare
This reverts commit b29fb86.
ee03976 to
6c5a4ba
Compare
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CORE-2018