fix(auth): add timeout to CAS popup login#40155
fix(auth): add timeout to CAS popup login#40155Tomeshwari-02 wants to merge 5 commits intoRocketChat:developfrom
Conversation
… audio/video recorder
… audio/video recorder
🦋 Changeset detectedLatest commit: 667beff The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tomeshwari-02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Why
CAS login previously waited only for the popup window to close. If the popup never closed, the auth flow could stall indefinitely with no recovery path.
Validation
git diff --check