Skip to content

Added pupil mask obscurations for imaging and spec modes.#75

Open
rzellem wants to merge 3 commits intoRomanSpaceTelescope:developfrom
rzellem:issue_74
Open

Added pupil mask obscurations for imaging and spec modes.#75
rzellem wants to merge 3 commits intoRomanSpaceTelescope:developfrom
rzellem:issue_74

Conversation

@rzellem
Copy link
Collaborator

@rzellem rzellem commented Dec 3, 2025

To address issue #74

@rzellem rzellem self-assigned this Dec 3, 2025
@rzellem rzellem added the enhancement New feature or request label Dec 3, 2025
@rzellem
Copy link
Collaborator Author

rzellem commented Dec 3, 2025

Note: I also updated the "Imaging -> FiltersSummary" folder to be simply "Filters" instead

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filenames in this README describe pupil mask obscurations for the Grism and Prism, but are in the imaging directory?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the above comment, the associated .ecsv files here are referring to masks on the imaging filters but are in the spectroscopy sub-directory?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this file, I am confused why the values in the second column are all the same and they are identical to the values in the second column of the "skinny" mask .ecsv file above. Given the different shape/size of the "skinny" filter mask and the Prism mask, this seems out of place. I think we should follow-up with Jeff and check that this is correct in the underlying file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants