fix: point .roomodes schema $id at the raw schema document (#12129)#12130
Open
shaun0927 wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix: point .roomodes schema $id at the raw schema document (#12129)#12130shaun0927 wants to merge 1 commit intoRooCodeInc:mainfrom
shaun0927 wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
The generated schema currently advertises a GitHub blob page as its $id, which returns HTML rather than the schema document itself. This updates the source-of-truth generator and checked-in schema to use a JSON-serving raw URL, and adds a regression assertion for the canonical metadata value. Constraint: Must keep the checked-in schema aligned with the generator output Rejected: Leave the blob URL in place | Schema consumers dereferencing $id receive HTML Confidence: high Scope-risk: narrow Reversibility: clean Directive: If the schema is moved in the future, keep $id pointing at a JSON-serving canonical URL Tested: pnpm --dir packages/types exec vitest run src/__tests__/roomodes-schema.spec.ts src/__tests__/roomodes-schema-sync.spec.ts Not-tested: External IDE/schema consumer end-to-end dereference behavior
shaun0927
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12129
Description
This PR keeps the fix intentionally narrow and only addresses the canonical schema identity value exposed by the generated
.roomodesschema.The current generator sets
$idto the GitHub blob URL:https://github.com/RooCodeInc/Roo-Code/blob/main/schemas/roomodes.jsonThat URL serves HTML, not the schema document itself. This PR changes the source-of-truth generator and the checked-in schema to use the raw JSON URL instead, and adds a regression assertion for the advertised
$id.Why this scope is narrow:
Files touched:
packages/types/src/roomodes-schema.tsschemas/roomodes.jsonpackages/types/src/__tests__/roomodes-schema.spec.tsTest Procedure
pnpm --dir packages/types exec vitest run src/__tests__/roomodes-schema.spec.ts src/__tests__/roomodes-schema-sync.spec.tsResult locally:
2test files passed27tests passedPre-Submission Checklist
Documentation Updates
Additional Notes
This is intended as a low-risk follow-up to
#11790/#11791, which fixed schema/content alignment but did not update the canonical$idto a JSON-serving URL.