Skip to content

[Fix] Slack failure notifications arrive late after task timeouts #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Fix] Slack failure notifications arrive late after task timeouts #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions packages/sdk/src/server/lib/task-runs/__tests__/finish-run.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 15 additions & 14 deletions packages/sdk/src/server/lib/task-runs/finish-run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,20 @@ export const finishRun = async ({
});
});

// Start notifying the originating Slack thread as soon as the terminal state
// is durable. Run it alongside the parent-task callback so neither remote
// notification delays the other.
const slackFailureNotification =
status === RunStatus.Failed && task.slackThreadTs
? sendSlackFailureNotification(run, channelProviderError).catch((err) => {
console.error(
`[finishRun] Failed to send Slack failure notification for run ${id}: ${
err instanceof Error ? err.message : String(err)
}`,
);
})
: Promise.resolve();

// Deterministic spawned-task feedback: when this run was launched by
// another task's run with notify-on-settle requested, deliver the outcome
// into that launching run's session (waking it if idle) so the parent
Expand All @@ -253,6 +267,7 @@ export const finishRun = async ({
status,
run.task.title,
);
await slackFailureNotification;

// Anonymous analytics (no-op unless enabled): terminal task outcome with
// non-identifying routing facts only.
Expand Down Expand Up @@ -321,20 +336,6 @@ export const finishRun = async ({
await cleanupGithubPrReviewArtifacts(run, status);
}

// Slack failure notification: post a thread reply when the run failed and
// was triggered from Slack (the task carries a Slack thread binding).
if (status === RunStatus.Failed && task.slackThreadTs) {
try {
await sendSlackFailureNotification(run, channelProviderError);
} catch (err) {
console.error(
`[finishRun] Failed to send Slack failure notification for run ${id}: ${
err instanceof Error ? err.message : String(err)
}`,
);
}
}

// Teams failure notification: post a thread reply when the run failed and
// was triggered from Teams (payload carries Teams communication metadata).
if (
Expand Down
Loading