Enable Docker-backed Roomote environment previews - #1317
Draft
daniel-lxs wants to merge 3 commits into
Draft
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nested_dockerenvironment capability for applications that launch containers dynamically without declaring a placeholder Docker projectWhy
The Roomote dogfood environment could create an inner task, but its controller failed before worker startup because the hosting sandbox had no Docker daemon. Its checked-in definition also did not run a nested preview proxy.
The existing runtime selected a Docker-capable Modal VM only when
docker_projectswas non-empty. Adding a fake Docker project would work around that behavior but would build and run an unrelated container. This change makes the actual requirement explicit instead.Complexity and security boundary
This PR intentionally does not add parent-runtime delegation, new token types, auth routes, source-control brokers, inference proxies, or credential propagation.
nested_dockeris optional and defaults off, so ordinary environments retain their current runtime and setup.web,docs, and wildcardpreviewports are public; the inner API on port 13001 remains local to the sandboxThe production runtime portion is intentionally small: schema support, Modal VM selection, Docker readiness, YAML preservation, and the demo-seed repair.
Test plan when a hosted environment is available
.roomote/environments/roomote.yamland launch a fresh Roomote environment task; do not reuse an older sandbox or snapshot.If manually configuring an independent inference credential proves too cumbersome, evaluate a separate follow-up for one non-delegatable, run-bound, inference-only capability. Source-control delegation and a general parent-runtime framework remain out of scope.
Validation
git diff --check