[Fix] Services stall during transient Redis outages - #1351
Draft
roomote-roomote[bot] wants to merge 3 commits into
Draft
[Fix] Services stall during transient Redis outages#1351roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
QueueEventsconnections that require unbounded request retries.Why this change was made
Transient Redis DNS failures previously produced bursts of unhandled ioredis error events while commands could remain pending indefinitely. The initial retry bound also affected BullMQ blocking connections, which require
maxRetriesPerRequest: nullto initialize.Impact
Ordinary Redis-dependent operations now fail within a bounded retry budget instead of hanging indefinitely, while BullMQ queue listeners retain their required blocking semantics. Both client types continue attempting recovery and emit actionable, credential-safe degradation and recovery summaries without one log line per reconnect attempt.