[Fix] Generic completion message appears while task is still running - #1369
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Fix] Generic completion message appears while task is still running#1369roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Missing-chat-closeout fallbacks now wait through a short grace period after completion settlement. The worker retains active tool call IDs even when those tools started before the stale completion, so it cannot arm the timer while work remains active. Meaningful follow-on runtime activity still cancels the pending fallback, while usage-only telemetry does not. A genuinely terminal harness teardown still flushes the fallback immediately.
Regression coverage exercises both orderings: activity that follows settlement and a tool that starts before
TaskCompleted, remains active beyond the grace window, then completes before teardown.Why this change was made
OpenCode can emit a stale idle while trailing tool work is still progressing. Roomote previously treated that completion as terminal and posted its generic fallback before the agent's real closeout arrived.
Impact
Slack-backed tasks no longer receive an early "I'm finished" message when the agent is still working, while tasks that truly exhaust closeout reminders retain their fallback response. Focused worker tests, type checks, lint, and the repository pre-push gates pass; two unrelated full-suite tests timed out only under parallel load and passed independently.