Skip to content

Add deployment-wide Notion access modes - #1371

Merged
mrubens merged 2 commits into
developfrom
codex/notion-deployment-access-mode
Aug 15, 2026
Merged

Add deployment-wide Notion access modes#1371
mrubens merged 2 commits into
developfrom
codex/notion-deployment-access-mode

Conversation

@mrubens

@mrubens mrubens commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make Notion an admin-managed deployment OAuth connection available to interactive tasks and automations
  • add a deployment access setting with fail-closed read-only behavior by default and an explicit read-write option
  • enforce the effective policy for both tool discovery and direct tool calls while preserving individual disabled-tool overrides
  • update the integrations UI, onboarding, setup guidance, Slack recommendations, public docs, and release notes

Rollout

The schema migration is additive. Existing personal Notion credentials are not promoted automatically; an administrator reconnects Notion once from Settings > Integrations. Missing or invalid access-mode values resolve to read-only.

Validation

  • pnpm lint
  • pnpm check-types
  • pnpm knip
  • pnpm --filter @roomote/docs check
  • Drizzle migration consistency check
  • focused types, API, web, Slack, worker, and cloud-agent tests (165 tests)

@roomote-community

roomote-community Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • Update the SDK MCP connection-router tests for Notion's deployment scope; the affected package test file currently has five failures.

Reviewed bd23346

Comment thread packages/types/src/mcp-oauth.ts
@mrubens
mrubens marked this pull request as ready for review August 15, 2026 17:34
@mrubens
mrubens merged commit daa23ff into develop Aug 15, 2026
18 checks passed
@mrubens
mrubens deleted the codex/notion-deployment-access-mode branch August 15, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant