Skip to content

[Chore] Replace vulnerable Storybook image parser - #1390

Merged
mrubens merged 1 commit into
developfrom
fix/image-size-dos-19t33j32qa1kn
Aug 16, 2026
Merged

[Chore] Replace vulnerable Storybook image parser#1390
mrubens merged 1 commit into
developfrom
fix/image-size-dos-19t33j32qa1kn

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Replace image-size@2.0.2 only on Storybook's Next.js Vite plugin path with probe-image-size@7.3.0.
  • Patch the plugin's ESM and CommonJS bundles to use the replacement's synchronous parser and fail closed for unsupported images.

Why this change was made

Dependabot alerts #96 and #97 cover infinite-loop denial of service flaws in image-size's JXL, HEIF, and ICNS parsers. Upstream has not published a patched image-size release, so this removes the vulnerable package from the lockfile without broadening the dependency update.

Impact

There is no intended product runtime change. Storybook keeps synchronous image metadata handling through a parser that rejects the published malformed ICNS and HEIF payloads promptly, and the repository's dependency minimum-age policy remains unchanged. Frozen installation, lint, type checking, the complete web client test suite, Knip, and dependency audit pass. The Storybook build still encounters its existing vfile/node:url browser-externalization failure after transforming the application modules; the replacement parser itself is exercised successfully with a repository PNG and the advisory payloads.

@roomote-community

roomote-community Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed d5e930b

@mrubens
mrubens marked this pull request as ready for review August 16, 2026 04:28
@mrubens
mrubens merged commit 21bf4f3 into develop Aug 16, 2026
18 checks passed
@mrubens
mrubens deleted the fix/image-size-dos-19t33j32qa1kn branch August 16, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants