[Chore] Replace vulnerable Storybook image parser - #1390
Merged
Conversation
Contributor
mrubens
marked this pull request as ready for review
August 16, 2026 04:28
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 16, 2026 04:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
image-size@2.0.2only on Storybook's Next.js Vite plugin path withprobe-image-size@7.3.0.Why this change was made
Dependabot alerts #96 and #97 cover infinite-loop denial of service flaws in
image-size's JXL, HEIF, and ICNS parsers. Upstream has not published a patchedimage-sizerelease, so this removes the vulnerable package from the lockfile without broadening the dependency update.Impact
There is no intended product runtime change. Storybook keeps synchronous image metadata handling through a parser that rejects the published malformed ICNS and HEIF payloads promptly, and the repository's dependency minimum-age policy remains unchanged. Frozen installation, lint, type checking, the complete web client test suite, Knip, and dependency audit pass. The Storybook build still encounters its existing
vfile/node:urlbrowser-externalization failure after transforming the application modules; the replacement parser itself is exercised successfully with a repository PNG and the advisory payloads.