Potential fix for code scanning alert no. 10: Uncontrolled command line#8
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/10
General fix: avoid passing user-derived strings directly into command arguments, even after filtering. Instead, transform inputs via a strict allowlist mapping to canonical hard-coded literals, and only pass mapped values onward.
Best fix here (without changing behavior): in
core/event_collector.py, add a canonical allowlist mapping for log source names and use it in bothcollect_eventsand_query_wel. This preserves existing functionality while ensuringsafe_log_sourcesis built strictly from compile-time constants. Keepsubprocess.runwith argument list and existing timeout bounds.Changes needed:
core/event_collector.pyDEFAULT_LOG_SOURCES, e.g.ALLOWED_LOG_SOURCES_MAP = {name: name for name in DEFAULT_LOG_SOURCES}.collect_events(around lines 92–95),_query_wel(around lines 121–125),with canonical mapping through
ALLOWED_LOG_SOURCES_MAP.get(src).Suggested fixes powered by Copilot Autofix. Review carefully before merging.