Potential fix for code scanning alert no. 2: Uncontrolled command line#9
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Rootless-Ghost/AtomicLoop/security/code-scanning/2
Best fix: stop interpolating raw user input into shell command text. Instead, escape/substitute values safely per target shell before building the final command.
In this codebase, the least disruptive fix is:
core/executor.pythat quotes each substituted value according to executor type (bash/shviashlex.quote,cmdvia conservative double-quote escaping,powershellvia single-quote escaping).#{var}replacement.core/engine.pyto call the new safe substitution function (for both main and cleanup commands), passingtest["executor_type"].This preserves existing functionality (still supports same templates and executors) while neutralizing command injection vectors from
input_arguments.Suggested fixes powered by Copilot Autofix. Review carefully before merging.