Conversation
- A lot of Roslyn caught clean-ups - Also we can't use message body, we have to use title when using a trace_chain
Add failing test for AspNetCore 3.1
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| public class ExceptionHandlerMiddlewareTests | ||
| { | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
Method OnlyLogsOnce has 27 lines of code (exceeds 25 allowed). Consider refactoring.
| Inspired by RollbarSharp, great library, just required too many tweaks to make play with .NET core well in my opinion. | ||
|
|
||
| # Testing | ||
| ## Testing |
There was a problem hiding this comment.
First header should be a top level header
CHANGELOG.md
Outdated
| <sup>Released: 2017/8/20</sup> | ||
|
|
||
| ## Features | ||
| ###### Features |
There was a problem hiding this comment.
Header levels should only increment by one level at a time
CHANGELOG.md
Outdated
| <sup>Released: 2017/4/21</sup> | ||
|
|
||
| ## Features | ||
| ###### Features |
There was a problem hiding this comment.
Header levels should only increment by one level at a time
CHANGELOG.md
Outdated
| <sup>Released: 2017/3/10</sup> | ||
|
|
||
| ## Features | ||
| ###### Features |
There was a problem hiding this comment.
Header levels should only increment by one level at a time
CHANGELOG.md
Outdated
| <sup>Released: 2017/2/26</sup> | ||
|
|
||
| ## Features | ||
| ###### Features |
There was a problem hiding this comment.
Header levels should only increment by one level at a time
CHANGELOG.md
Outdated
| <sup>Released: 2016/9/30</sup> | ||
|
|
||
| ## Features | ||
| ###### Features |
There was a problem hiding this comment.
Header levels should only increment by one level at a time
| # 0.7.0 | ||
| # Releases | ||
|
|
||
| ## 0.8.0 |
There was a problem hiding this comment.
First header should be a top level header
| this.RollbarMock.Setup(m => m.SendMessage(It.IsAny<RollbarLevel>(), It.IsAny<string>())).Returns(() => Task.FromResult<Payloads.Response>(null)); | ||
| this.Logger = new RollbarDotNetLogger(this.RollbarMock.Object); | ||
| RollbarMock = new Mock<Rollbar>(null, null, null); | ||
| RollbarMock.Setup(m => m.SendException(It.IsAny<RollbarLevel>(), It.IsAny<Exception>())).Returns(() => Task.FromResult<Payloads.Response>(null)); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| public KestrelTests() | ||
| { | ||
| RollbarMock = new Mock<Rollbar>(null, null, null); | ||
| RollbarMock.Setup(m => m.SendException(It.IsAny<RollbarLevel>(), It.IsAny<Exception>())).Returns(() => Task.FromResult<Payloads.Response>(null)); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| this.Logger = new RollbarDotNetLogger(this.RollbarMock.Object); | ||
| RollbarMock = new Mock<Rollbar>(null, null, null); | ||
| RollbarMock.Setup(m => m.SendException(It.IsAny<RollbarLevel>(), It.IsAny<Exception>())).Returns(() => Task.FromResult<Payloads.Response>(null)); | ||
| RollbarMock.Setup(m => m.SendMessage(It.IsAny<RollbarLevel>(), It.IsAny<string>())).Returns(() => Task.FromResult<Payloads.Response>(null)); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| { | ||
| RollbarMock = new Mock<Rollbar>(null, null, null); | ||
| RollbarMock.Setup(m => m.SendException(It.IsAny<RollbarLevel>(), It.IsAny<Exception>())).Returns(() => Task.FromResult<Payloads.Response>(null)); | ||
| RollbarMock.Setup(m => m.SendMessage(It.IsAny<RollbarLevel>(), It.IsAny<string>())).Returns(() => Task.FromResult<Payloads.Response>(null)); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
Replace non-concurrent dict with ConcurrentCache
|
Code Climate has analyzed commit 00e7f6d and detected 33 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
2 participants
No description provided.