Change Hypixel Mod API from embedded to required dependency#43
Open
TomekoYT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shading mod dependencies is a bad practice that used to be common in the modding community. When two mods shade the same dependency, it gets loaded twice, which can cause several issues. Currently, the game crashes on startup when both Mellow and Hypixel Mod API are present in the same modpack.
This PR fixes the issue by requiring users to include Hypixel Mod API separately in their modpack instead of embedding it inside Mellow. This approach is standard practice in modern Fabric/NeoForge modding.