Lab2#32
Open
parfen01 wants to merge 16 commits into
Open
Conversation
Update README.md
Rrenkens
reviewed
Dec 23, 2022
| "hobosVillage" : { | ||
| "eatingTime" : 10, | ||
| "ingredientsCount" : [ | ||
| 11, |
Owner
There was a problem hiding this comment.
Я бы мап сделал, так наугад не совсем понятно.
| } | ||
|
|
||
| public boolean isWorking() { | ||
| return isWorking; |
Owner
There was a problem hiding this comment.
У нас же тут гонка? Ты вызываешь isWorking из разных потоков, а еще можешь вызвать либо start либо stop.
| } | ||
| isWorking = false; | ||
| for (Thread i : workingThreads) { | ||
| if (i.getState() != Thread.State.WAITING) { |
Contributor
Author
There was a problem hiding this comment.
Так суть в том, что мы не джойним тех, кто вэйтит, ибо это бесконечное ожидание
| "cucumber" | ||
| ] | ||
| }, | ||
| "Tunnel" : 7, |
Owner
There was a problem hiding this comment.
Тут тоже непонятно, что это за константа.
Comment on lines
+45
to
+48
| if (productsCount.get(product) == 0) { | ||
| return false; | ||
| } | ||
| productsCount.decrementAndGet(product); |
Owner
There was a problem hiding this comment.
Тут все может поменяться:
Пусть у нас 1 еденица товара:
- Проверяем на 0, 1 != 0.
- Вклинивается другой пототок, проверяем на 0 и забирает товар.
- Просыпается первый и забирает товар, в итоге ушли в минус.
Comment on lines
+29
to
+31
| productsCount.set(product, Math.min(maxProductCapacity[product], | ||
| productsCount.get(product) + ship.getShipCapacity())); | ||
| sleep((productsCount.get(product) - pred) * 1000L / unloadingSpeed); |
Owner
There was a problem hiding this comment.
Тут надо сохранять и использовать локальные перменные, ибо за это время могу придти и стырить и тогда получим неверное время ожидание.
Owner
|
В итоге 8. +1 за Condition Variable. |
Rrenkens
added
question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.