Lab2#35
Open
DaniilDomnin wants to merge 9 commits into
Open
Conversation
Rrenkens
reviewed
Dec 24, 2022
| this.docks = docks; | ||
| ship_count = new AtomicInteger(); | ||
| consoleLOgger = Logger.getLogger(" "); | ||
| Thread thread = new Thread(docks::StartStealing); |
Owner
There was a problem hiding this comment.
Не стоит делать такое в конструкторе.
|
|
||
| private void Generating() throws InterruptedException { | ||
| while (true) { | ||
| if (ship_count.get() < max_ships) { |
Comment on lines
+24
to
+35
| if (ship_count.get() < max_ships) { | ||
| Ship ship = generator.GenerateShip(); | ||
| consoleLOgger.log(Level.INFO, "Generate new ship"); | ||
| Thread thread = new Thread(()->{ | ||
| try { | ||
| Uploading(ship); | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| }); | ||
| thread.start(); | ||
| ship_count.incrementAndGet(); |
Owner
There was a problem hiding this comment.
Между этими строчками можем произойти множество событий и кораблей сюда зайдет намного больше чем max_ship и ship_count может даже в минус уйти. И не хорошо оставлять висеть потоки.
Owner
|
Очень плохая декомпозиция, но по требованиям подходит. В итоге 8. |
Rrenkens
added
question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.