Lab 1#36
Open
shandomruffle wants to merge 18 commits into
Open
Conversation
Rrenkens
reviewed
Dec 3, 2022
| var gen = new PoolTaskGenerator(false, | ||
| new TextTask("Какая (по слухам) подработка у С*****ча?", "сборщик мусора"), | ||
| new TextTask("Как называется человек, убегающий от каннибала?", "фастфуд"), | ||
| new TextTask("Какой вид порно не могут снять бомжи?", "домашнее"), |
Author
There was a problem hiding this comment.
сказали же захардкодить...
| boolean interactionFinished = false; | ||
| while (!interactionFinished) { | ||
| var query = inputLineNormalized(); | ||
| switch (query) { |
Owner
There was a problem hiding this comment.
Вот если бы у меня не было кода, я бы не узнал об этом никак. Про help & exit точно.
Author
There was a problem hiding this comment.
фикс, выводится хелпа с самого начала
| default -> { | ||
| if (map.containsKey(query)) { | ||
| System.out.println("Starting quiz \"" + query + "\"!"); | ||
| Quiz clone; |
Owner
There was a problem hiding this comment.
Можно дать более осмысленное название.
| * Оценка выставляется только в конце! | ||
| */ | ||
| public double getMark() { | ||
| return (double)getCorrectAnswerNumber() / getTotalAnswerNumber(); |
Owner
There was a problem hiding this comment.
Ну так точно не должно быть. Оценка, которая является отношением количества правильных ответов к количеству всех вопросов.
| */ | ||
| GroupTaskGenerator(Iterable<TaskGenerator> generators) { | ||
| this.generators = new ArrayList<>(); | ||
| for (var gen : generators) { |
Owner
There was a problem hiding this comment.
Либо stream api, либо generators.forEach(this.generators::add).
| Collections.addAll(this.generators, generators); | ||
| } | ||
|
|
||
| public GroupTaskGenerator(TaskGenerator other, CopyParameter f) { |
| this(allowDuplicate, Arrays.stream(tasks).collect(Collectors.toList())); | ||
| } | ||
|
|
||
| public PoolTaskGenerator(TaskGenerator other, CopyParameter f) { |
| ) { | ||
| this.pool = new ArrayList<>(tasks); | ||
| this.allowDuplicate = allowDuplicate; | ||
| if (!allowDuplicate) { |
Owner
There was a problem hiding this comment.
Тут allowDuplicate должен проверить и на входе на одинаковые задачи.
| * значение - сам тест {@link by.toharrius.quizer.Quiz} | ||
| */ | ||
| private static @NotNull Map<String, Quiz> getQuizMap() { | ||
| var map = new HashMap<String, Quiz>(); |
Owner
There was a problem hiding this comment.
Можно дать более осмысленное название.
| } | ||
| default MathOperation generateMathOperation() { | ||
| var r = ThreadLocalRandom.current(); | ||
| int index = r.nextInt((int)getAllowed().stream().count()); |
Owner
|
Ну пока что такая оценка:
Допы:
В итоге 8.2. В остальном классная работа и хорошо, что подумал, что один и тот же тест, может быть вызван много раз. +3 за допы. |
Rrenkens
added
wontfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.