fix: remove run-id from download-artifact in deploy job - #8
Merged
Conversation
The package and deploy jobs are in the same workflow run. download-artifact@v4 finds artifacts by name within the current run automatically — no run-id or github-token needed. Using github.event.workflow_run.id (the upstream Build & Push run) caused artifact not found errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
deployjob was failing with:The
download-artifact@v4step hadrun-id: ${{ github.event.workflow_run.id }}, which resolves to the Build & Push Images run ID — the upstream workflow that triggered this one. That run has no Zarf tarball.Fix
Remove
run-idandgithub-tokenentirely. Thepackageanddeployjobs are in the same workflow run, sodownload-artifact@v4finds the artifact automatically by name within the current run — norun-idneeded.🤖 Generated with Claude Code