Add DEFAULT_MINOR constant #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
approved these changes
Jan 22, 2026
| MULTIPLIER_REGEXP = Regexp.new(format('^(.*?\d)(%s)\b([^\d]*)$', MULTIPLIER_SUFFIXES.keys.join('|')), 'i') | ||
|
|
||
| DEFAULT_DECIMAL_MARK = '.'.freeze | ||
| DEFAULT_MINOR = "00".freeze |
Member
There was a problem hiding this comment.
Should we start marking these constants as private?
Suggested change
| DEFAULT_MINOR = "00".freeze | |
| DEFAULT_MINOR = "00".freeze | |
| private_constant :DEFAULT_MINOR |
Contributor
Author
There was a problem hiding this comment.
I agree, but maybe it could be in a separate PR if there are other constants that need a visibility change as well. What other constants should be private?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Since I'm working from a fork, I realized I can't easily chain the PRs here. To keep things organized, I’ll send the changes one by one and wait for your feedback before opening the next one.
In this PR, I introduced a
DEFAULT_MINORconstant to replace a recurring hardcoded"00"or0.