derive: Implement reconstruct_path helper for cmp#4395
Open
Pasta-coder wants to merge 1 commit intoRust-GCC:masterfrom
Open
derive: Implement reconstruct_path helper for cmp#4395Pasta-coder wants to merge 1 commit intoRust-GCC:masterfrom
Pasta-coder wants to merge 1 commit intoRust-GCC:masterfrom
Conversation
CohenArthur
reviewed
Jan 18, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
So I'm not necessarily against these changes, but the goal with this comment here was to do something like #3799 but for other base classes. I think we can merge this but I'd rather see the entire thing being implemented
Contributor
Author
|
thank you for the review . will modify accordingly . |
Pasta-coder
force-pushed
the
fix/derive-cmp-reconstruct
branch
4 times, most recently
from
35e4800 to
84223c7
Compare
Contributor
Author
|
@CohenArthur Thanks for the review ! I've refactored the implementation to follow the established thankyou . |
Pasta-coder
force-pushed
the
fix/derive-cmp-reconstruct
branch
from
84223c7 to
78363a6
Compare
Pasta-coder
force-pushed
the
fix/derive-cmp-reconstruct
branch
3 times, most recently
from
c85f3df to
7e759df
Compare
This patch implements the `reconstruct` pattern for the `Path` hierarchy and its constituents (segments, generic args, qualified paths). Previously, derive expansion macros (like `derive(PartialEq)`) had to manually rebuild paths field-by-field to ensure fresh NodeIDs. This change moves that logic into the AST classes themselves, allowing paths to be deeply reconstructed uniformly. This ensures that expanded code has unique NodeIDs, which is critical for correct name resolution. gcc/rust/ChangeLog: * ast/rust-path.h (GenericArgsBinding::reconstruct): New method. (GenericArg::reconstruct): New method. (GenericArgs::reconstruct): New method. (PathExprSegment::reconstruct): New method. (PathInExpression::reconstruct): New method. (TypePathSegmentGeneric::reconstruct_impl): New method. (TypePathFunction::reconstruct): New method. (TypePathSegmentFunction::reconstruct_impl): New method. (QualifiedPathType::reconstruct): New method. (QualifiedPathInExpression::reconstruct): New method. (QualifiedPathInType::reconstruct_impl): New method. * expand/rust-derive-cmp-common.cc (EnumMatchBuilder::tuple): Use path.reconstruct(). (EnumMatchBuilder::strukt): Use path.reconstruct(). Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
fix/derive-cmp-reconstruct
branch
from
7e759df to
7b27b33
Compare
Contributor
Author
|
The changes implement also tagging @powerboat9 to get reviews . thankyou . |
powerboat9
approved these changes
Feb 7, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a local helper to clone
PathInExpression objects. This allows removing duplicate calls to , fulfilling the TODOs in EnumMatchBuilder.
This ensures the self and other paths are identical without reconstructing them from strings twice.
gcc/rust/ChangeLog: