Fix aaudio device name in device.description().name()

[SuperKenVery]

#965 fixed this for device.name(), which is now a deprecated method. I let .description().name() return the same name.

[roderickvd]

I'm not super-clear on the intent, can you elaborate? It seems that currently returning info.product_name is the same that #965 did?

[SuperKenVery]

In #965, the name is changed to product name and device type, on android. Product name is always the device model.

You may see the code diff, it's a one line change, and the implementation of name is a few lines above.

[roderickvd]

If I understand correctly, you are saying that you prefer the behavior of #965? Because I found it weird that a "name" includes a device type and an address.

[SuperKenVery]

Yes on android. The product name on android is same for every device; it's always the phone product name.

Without this pr, all of them will be PJX110

[setoelkahfi]

I didn't see this before working on fixing #969 I have my own patch locally. What's the status here?

[SuperKenVery]

@setoelkahfi seems we are doing the same thing, with a little bit different implementation details 😉

[setoelkahfi]

@setoelkahfi seems we are doing the same thing, with a little bit different implementation details 😉

@SuperKenVery would you mind using my changes instead?

[SuperKenVery]

@setoelkahfi My version ensures that device.name() returns the same value as device.description().name(), would this be preferred?

cc @roderickvd

[setoelkahfi]

@setoelkahfi My version ensures that device.name() returns the same value as device.description().name(), would this be preferred?

cc @roderickvd

My changes are here. I also filter out the devices based on the direction (output, input).

The CI are failing but don't seem to be related to my changes.