primefield: add PrimeFieldExt trait - #1809
Merged
Merged
Conversation
Adds a trait for specifying the endianness of the serialized representation of a field element as a stopgap until zkcrypto/rfcs#4 is accepted. This uses the `ByteOrder` enum and replaces the previous `FIELD_REPR_IS_BE` flag on `PrimeCurveParams`. It also means `Radix16Decomposition` now "Just Works" and doesn't need an endianness parameter passed to `new`. The `primefield::monty_field_element!` macro now writes impls for this trait, sourcing the endianness information from the `MontyFieldParams`.
Merged
tarcieri
added a commit
that referenced
this pull request
Sep 3, 2026
This release contains a breaking change (#1913) to use `primefield` traits for determining endianness. The original hope was that the existing `ff` traits could be used instead (zkcrypto/ff#158), but we ended up having to ship our own traits (#1809) due to inaction from upstream. This is a release blocker for `bignp256` which needs little endian support, so we're making this change hoping that despite being breaking it should be compatible with all existing usages. We can re-evaluate if that winds up not being the case. The `wnaf` v0.14.0 release will be yanked accordingly to mandate the new bounds.
tarcieri
added a commit
that referenced
this pull request
Sep 3, 2026
This release contains a breaking change (#1913) to use `primefield` traits for determining endianness. The original hope was that the existing `ff` traits could be used instead (zkcrypto/ff#158), but we ended up having to ship our own traits (#1809) due to inaction from upstream. This is a release blocker for `bignp256` which needs little endian support, so we're making this change hoping that despite being breaking it should be compatible with all existing usages. We can re-evaluate if that winds up not being the case. The `wnaf` v0.14.0 release will be yanked accordingly to mandate the new bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a trait for specifying the endianness of the serialized representation of a field element as a stopgap until zkcrypto/rfcs#4 is accepted.
This uses the
ByteOrderenum and replaces the previousFIELD_REPR_IS_BEflag onPrimeCurveParams. It also meansRadix16Decompositionnow "Just Works" and doesn't need an endianness parameter passed tonew.The
primefield::monty_field_element!macro now writes impls for this trait, sourcing the endianness information from theMontyFieldParams.