[hex-literal] Add new hex_custom_padding!() macro; enables custom padding between hex characters - #1242
Closed
mcronce wants to merge 1 commit into
Closed
[hex-literal] Add new hex_custom_padding!() macro; enables custom padding between hex characters#1242mcronce wants to merge 1 commit into
mcronce wants to merge 1 commit into
Conversation
…pports custom padding between hex characters in addition to just whitespace
Member
|
Hm. Maybe it would be better to just add |
Member
|
Sure, seems fine |
Member
|
Closing in favor of #1244. |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, my use case is using key hashes from Android signing key reports, which are colon-delimited (e.g.
55:1A:14:14:BA:03:DA:1B:23:ED:EA:40:4A:BE:88:D7:C4:83:D1:E2:85:42:41:2C:22:73:D3:52:0B:6E:A7:5F). Removing the colons before use would work, but keeping them matching the signing key in source code provides a lot of value in terms of maintainabilityImplemented by making the existing
hex!()macro a wrapper around this, with no padding setProbably needs docs; as long as this seems like something the community is comfortable with, I'll add a doc comment to the macro