[receive] use get() in has_all_pages() instead of unguarded array index#53
Merged
stewartadam merged 4 commits intoRustLight:mainfrom Dec 31, 2025
Conversation
Docker ipv4 tests run OK on local pc. trigger GH action tests again.
stewartadam
approved these changes
Dec 31, 2025
stewartadam
reviewed
Dec 31, 2025
stewartadam
requested changes
Dec 31, 2025
Contributor
stewartadam
left a comment
stewartadam
left a comment
There was a problem hiding this comment.
see comment about fencepot error
stewartadam
approved these changes
Dec 31, 2025
bruingineer
deleted the
refactor-has-all-pages-to-remove-array-out-of-bounds-lookup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If pages were duplicated or received out of order, it's possible that has_all_pages() could have an array lookup that causes a panic. Using get() is a safe way to check for a value and ensure the array bounds are within range.
fixes #47