Protect blitzcc target-flag workflow coverage#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-technical summary
This hardens the developer and CI workflows around
blitzcctarget selection. The repository now depends on the-targetflag for documented local testing and recent macOS alpha work, so this change adds explicit checks that accepted targets still compile and unsupported targets still fail clearly.Why this matters now: the
-targetparser was added only recently, after the documented workflow had already drifted into a broken state. Locking that contract into the test entrypoints makes the next regression show up immediately in the same scripts contributors and CI already run.After this change, the system is better because target-selection regressions fail fast instead of silently breaking
test.sh,test.bat, or the host-specific CI assumptions they encode.Technical summary
-targetcontract checks totest.shbefore the existing suite runs.test.batforhost,windows-x86, and rejectedmacos-arm64usage.Additional notes
cmd.exeis unavailable on this host.