Skip to content

Protect blitzcc target-flag workflow coverage#29

Merged
CoreyRDean merged 3 commits into
developfrom
fix/target-flag-regression-coverage
May 12, 2026
Merged

Protect blitzcc target-flag workflow coverage#29
CoreyRDean merged 3 commits into
developfrom
fix/target-flag-regression-coverage

Conversation

@CoreyRDean
Copy link
Copy Markdown
Collaborator

Non-technical summary

This hardens the developer and CI workflows around blitzcc target selection. The repository now depends on the -target flag for documented local testing and recent macOS alpha work, so this change adds explicit checks that accepted targets still compile and unsupported targets still fail clearly.

Why this matters now: the -target parser was added only recently, after the documented workflow had already drifted into a broken state. Locking that contract into the test entrypoints makes the next regression show up immediately in the same scripts contributors and CI already run.

After this change, the system is better because target-selection regressions fail fast instead of silently breaking test.sh, test.bat, or the host-specific CI assumptions they encode.

Technical summary

  • Added explicit -target contract checks to test.sh before the existing suite runs.
  • Verified the host alias still compiles on Unix hosts, the native macOS target still compiles on Darwin, and an unsupported foreign target is rejected with the expected error.
  • Added matching Windows-side checks to test.bat for host, windows-x86, and rejected macos-arm64 usage.
  • Reused the existing test entrypoints instead of introducing a parallel harness, so the new coverage runs anywhere the repository already runs its test scripts.
  • Preserved the existing macOS alpha runtime smoke behavior while consolidating temporary artifacts under one cleanup directory.
  • Breaking changes: none.

Additional notes

  • Trade-off: this improves workflow-contract coverage without introducing a dedicated CLI unit-test harness; that keeps the scope small and aligned with current repo norms.
  • Deferred follow-up: if the project later adds more real codegen targets, these script-level assertions should grow with that matrix or move into a more formal CLI test harness.
  • Remaining gap: Windows-side execution of the new batch assertions was reviewed statically in this macOS environment, but not run live here because cmd.exe is unavailable on this host.

@CoreyRDean CoreyRDean added the bug Something isn't working label May 11, 2026
@CoreyRDean CoreyRDean marked this pull request as ready for review May 12, 2026 16:25
@CoreyRDean CoreyRDean requested a review from a team as a code owner May 12, 2026 16:25
@CoreyRDean CoreyRDean merged commit d9ac67a into develop May 12, 2026
4 checks passed
@CoreyRDean CoreyRDean deleted the fix/target-flag-regression-coverage branch May 12, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant