Harden Windows release packaging#33
Draft
CoreyRDean wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-technical summary
This hardens the Windows release packaging path so
publish.batstops on real packaging failures and no longer tries to copy optional artifacts that are not present. That matters now because the repo’s Windows publisher should be as trustworthy as the Unix publisher when maintainers cut release archives.Technical summary
publish.batfail fast ifcompile.batfails instead of continuing into archive staging:copy_tree_if_existshelper so release packaging only copies directories that are actually present.vsixis treated as optional instead of producing a noisy wildcard copy failureCompress-Archiverelease\\README.txtcontent without literal quote characters and align the wording with the Unix publisher more closelyAdditional notes
Trade-offs: validation on this macOS host is static only for the batch script because
cmd.exeis not available here.Follow-up intentionally deferred: there is still no repo-local automated Windows batch regression harness; hosted Windows CI remains the stronger proof path for runtime execution of
publish.bat.Breaking changes: none.