fix(ux): /help string drift — 9 commands had wrong syntax or wrong gate

[CoreyRDean]

Summary

Audit of SendChatHelp + SendChatHelpDetail (ServerNet.bb:31-109) against the actual Case dispatch in UpdateNetwork found 9 in-game help strings that misdescribed their command. Players running /help <cmd> would learn the wrong syntax, type something the parser silently rejects, and lose several seconds figuring out what's wrong.

The recon trigger was PR #290's reviewer, who spotted that /script <name>[,<params>] was actually /script <name>,<func> (handler splits to Name + Func and ignores any 3rd arg). That fix went in last PR; this PR is the comprehensive sweep of every remaining drift.

Defects fixed

Command	Old help	What handler actually does	New help
/warp	<area>[,<x>,<y>,<z>] (non-DM Info category)	DM-gated; 2nd arg is Instance, not coordinates; warps to area's first PortalName$[i]	<area>[,<instance>] -- warp self to area's first portal (moved to DM-only)
/warpother	<player>,<area>[,<x>,<y>,<z>]	Same — 3rd arg is Instance, not coords	<player>,<area>[,<instance>] -- warp another player
/yell	"shout to your entire area"	Walks FirstOnlinePlayer engine-wide chain (:408-414)	"shout to every online player on the server"
/xp	<player>,<amount>	GiveXP(AI, Int(Params$)) — single arg, self (:335)	<amount> -- grant XP to self
/gold	<player>,<amount>	AI\Gold = AI\Gold + Int(Params$) (:340)	<amount> -- adjust own gold (negative to deduct)
/setattribute	<player>,<attr>,<value>	2-arg comma split; targets AI (:354)	<attr>,<value> -- set own attribute
/setattributemax	<player>,<attr>,<value>	Same shape	<attr>,<value> -- set own max attribute
/ability	<player>,<ability>	Name,Level 2-arg; AddSpell(AI, ...) (:577-580)	<ability>,<level> -- grant own ability at level
/give	<player>,<item>[,<amount>]	Upper$(Params$) whole-string item-name match; assigns to AI (:588-602)	<item> -- spawn item into own inventory
/gm	"broadcast as GM to all players"	Walks FirstOnlinePlayer but re-checks A2\Account.IsDM (:422-427) — DM-to-DM only	"broadcast as GM to all DMs"

/warp also moved out of the non-DM Info summary line into the DM-only summary line, since its handler at :531 requires Account\IsDM.

Block comment added

Above the DM-only If block in SendChatHelpDetail, a comment now records the self-target invariant for future contributors:

All grant commands target self — the handlers in this file uniformly call GiveXP/AddSpell/etc. on AI, never on a Params-named player. /warpother is the sole exception that takes a target.

This keeps the next reviewer from re-introducing the <player>,... mistake when they add a new DM command.

Doc follow-up

Two stale entries in docs/protocol/packets/P_ChatMessage.md (the catalogue I just merged in #290) had the same <x>,<z> mistake copied from the broken help text. Corrected.

Test plan

• compile.bat -t clean (Server + Client + GUE + Project Manager)
• All 9 help strings cross-checked against their Case handler at the line range cited in the table above
• Doc catalogue (docs/protocol/packets/P_ChatMessage.md) updated for /warp and /warpother
• CI green

🤖 Generated with Claude Code