Major improvements to ViewMembersWithRole plugin#2
Open
blancodagoat wants to merge 3 commits into
Open
Conversation
blancodagoat
commented
Jan 6, 2026
blancodagoat
commented
- Bug fixes: Fixed directory name typo (componenents → components)
- Robustness: Improved error handling with ErrorBoundary and null checks
- Fallbacks: Added fallback mechanisms when Discord API endpoints are unavailable
- Performance: Changed rolesFetched from Array to Set for O(1) lookups
- UI: Created RoleCircle component with CSS variable support for dynamic colors
- Types: Updated to use @vencord/discord-types and improved TypeScript types
- Accessibility: Added alt/title attributes to images
- Loading states: Better loading indicators and error messages
- Code quality: Proper cleanup in useEffect hooks with cancellation flags
- CSS: Added background-color to role circle with CSS variable support
- Bug fixes: Fixed directory name typo (componenents → components) - Robustness: Improved error handling with ErrorBoundary and null checks - Fallbacks: Added fallback mechanisms when Discord API endpoints are unavailable - Performance: Changed rolesFetched from Array to Set for O(1) lookups - UI: Created RoleCircle component with CSS variable support for dynamic colors - Types: Updated to use @vencord/discord-types and improved TypeScript types - Accessibility: Added alt/title attributes to images - Loading states: Better loading indicators and error messages - Code quality: Proper cleanup in useEffect hooks with cancellation flags - CSS: Added background-color to role circle with CSS variable support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.