Send the job as a parameter to handle_error#76
Closed
rafaeelaudibert wants to merge 3 commits intoRykian:masterfrom
Closed
Send the job as a parameter to handle_error#76rafaeelaudibert wants to merge 3 commits intoRykian:masterfrom
rafaeelaudibert wants to merge 3 commits intoRykian:masterfrom
Conversation
Author
|
Actually, #60 already does it. I'll let us use their implementation because it's simpler and it's been there for a while now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our use case, we want to be able to know which job failed, besides that, an error happened. To support it, we are now also sending the
@jobinstance variable to thehandle_errorblock.